Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: use RTL in the version selector tests #1435

Merged
merged 3 commits into from
Jan 17, 2024
Merged

Conversation

erikian
Copy link
Member

@erikian erikian commented Aug 6, 2023

Another step towards #1408. I've added a couple of changes on top of just migrating the tests to RTL (open to feedback if any of them are a bad idea):

  • extracted some duplicate version mocking logic to a separate file
  • created a helper function to render the VersionSelect component - I didn't do it in a beforeEach block because we only need to render the whole component in one test
  • added a missing test for the renderVersionContextMenu component

I've also included the testMatch change from #1434 just so the RTL tests will run on CI for this PR. This means that #1434 should land first to keep things separate and to prevent it from becoming an empty changeset.

@erikian erikian requested review from codebytere and a team as code owners August 6, 2023 19:58
@erikian erikian force-pushed the test/version-selector-rtl branch from 93cd467 to f3fb27f Compare August 24, 2023 22:35
@coveralls
Copy link

coveralls commented Aug 24, 2023

Coverage Status

coverage: 87.213% (+0.2%) from 87.009%
when pulling 708e7fa on test/version-selector-rtl
into 1ec5c07 on main.

@ckerr
Copy link
Member

ckerr commented Jan 9, 2024

Looks like this was approved a a couple of months ago but not merged.

@erikian is this PR still something that should be merged; and if so, could you update the PR to resolve the conflicts that have built up in the interim? 😸

@erikian
Copy link
Member Author

erikian commented Jan 10, 2024

@ckerr I'll try to get this PR rebased later this week, thanks for the reminder!

@erikian erikian force-pushed the test/version-selector-rtl branch 3 times, most recently from 5a2fdfa to 6e1e079 Compare January 13, 2024 23:22
@erikian erikian force-pushed the test/version-selector-rtl branch from 6e1e079 to e667281 Compare January 16, 2024 01:06
@erikian erikian force-pushed the test/version-selector-rtl branch from da4f64c to 708e7fa Compare January 17, 2024 02:03
@erikian erikian merged commit af90609 into main Jan 17, 2024
9 checks passed
@erikian erikian deleted the test/version-selector-rtl branch January 17, 2024 02:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants