-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make bind parameter take the actual interface, and port the port #121
base: master
Are you sure you want to change the base?
Conversation
BREAKING CHANGE: This renames the old `bind` configuration option to `port` and introduces a new configuration option `bind` that now takes a single IP to listen on.
@badboy |
Changed corvus.conf. |
In addition: this includes the minimal "get ipv6 working" patch. I did a manual test, but it would need to be tested more before getting merged. |
I fixed the test now, but it's now lacking any tests for the new |
For our production case, we get no benefits but rather extra work(config file compatibility) by merging this, but I think this is the right thing to do, so we'll merge this later on, next release I hope. You could make changes until then. |
I do understand the friction it will cause due to config file changes. I'd like to test this a bit further, including proper tests and IPv6 support. |
|
lol nope. |
No description provided.