Integration tests for GraphNodeComment #11575
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also a little refactoring in preparation for new implementation.
kazcw
added
the
CI: No changelog needed
kazcw
requested review from
Frizi,
farmaazon,
vitvakatu and
AdRiley
as code owners
farmaazon
approved these changes
Nov 18, 2024
Comment on lines
+12
to
+13
| await nodeComment.click() | ||
| await page.keyboard.press(`${CONTROL_KEY}+A`) |
There was a problem hiding this comment.
Just checking, as I don't know exactly how it works: if the click changes some HTML elements (like, the editable input appears only after clicking), we should add an expect here, otherwise Ctrl+A may be applied before input appears resulting in flaky test.
kazcw
added a commit
that referenced
this pull request
Nov 18, 2024
Eliminates Lexical dependency. Stacked on #11575 and #31607.
kazcw
added
the
CI: Keep up to date
5 tasks
|
Merged into #11564. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Integration tests for GraphNodeComment
Also a little refactoring in preparation for CM-based PlainTextEditor.
Important Notes
Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:
Scala,
Java,
TypeScript,
and
Rust
style guides. In case you are using a language not listed above, follow the Rust style guide.
or the Snowflake database integration, a run of the Extra Tests has been scheduled.