Removed "callback failed" error message from tls_inspector.cc #240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The TLS inspector listener filter installs a servername callback (using SSL_CTX_set_tlsext_servername_callback()). That callback obtains the server name and then halts the handshake by returning SSL_TLSEXT_ERR_ALERT_FATAL. It does this because once it has obtained the server name, it has no need to progress the handshake any further because it's only "peeking" at the received data, and not actually doing the "real" handshake. In upstream envoy, on BoringSSL, this is OK, but on OpenSSL the SSL_TLSEXT_ERR_ALERT_FATAL return value causes a "callback failed" error message to be logged. It turns out this error message is innocuous, but it is unsigtly and distracting, so this commit removes it by returning SSL_TLSEXT_ERR_OK instead. Signed-off-by: Ted Poole <tpoole@redhat.com>
tedjpoole
requested review from
jwendell and
twghu
and removed request for
ggreenway
jwendell
reviewed
Jul 24, 2024
There was a problem hiding this comment.
I don't think this works.
Now I'm getting this error:
debug envoy connection external/envoy/source/extensions/transport_sockets/tls/ssl_socket.cc:280 [Tags: "ConnectionId":"708"] remote address:10.244.0.19:46782,TLS_error:|268435709:SSL routines:OPENSSL_internal:NO_COMMON_SIGNATURE_ALGORITHMS:TLS_error_end thread=30
It seems that we're just replacing the "callback error" with "NO_COMMON_SIGNATURE_ALGORITHMS".
|
We have always had this change in maistra/envoy going way back. We just hadn't copied it into envoy-openssl yet. |
twghu
approved these changes
Jul 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The TLS inspector listener filter installs a servername callback (using
SSL_CTX_set_tlsext_servername_callback()). That callback obtains the server name and then halts the handshake by returningSSL_TLSEXT_ERR_ALERT_FATAL. It does this because once it has obtained the server name, it has no need to progress the handshake any further because it's only "peeking" at the received data, and not actually doing the "real" handshake. In upstream envoy, on BoringSSL, this is OK, but on OpenSSL theSSL_TLSEXT_ERR_ALERT_FATALreturn value causes a "callback failed" error message to be logged. It turns out this error message is innocuous, but it is unsightly and distracting, so this commit removes it by returningSSL_TLSEXT_ERR_OKinstead.