Commits on Jul 24, 2024

1. Removed "callback failed" error message from tls_inspector.cc …

   The TLS inspector listener filter installs a servername callback (using
   SSL_CTX_set_tlsext_servername_callback()). That callback obtains the server
   name and then halts the handshake by returning SSL_TLSEXT_ERR_ALERT_FATAL.
   It does this because once it has obtained the server name, it has no need
   to progress the handshake any further because it's only "peeking" at the
   received data, and not actually doing the "real" handshake. In upstream
   envoy, on BoringSSL, this is OK, but on OpenSSL the SSL_TLSEXT_ERR_ALERT_FATAL
   return value causes a "callback failed" error message to be logged. It turns
   out this error message is innocuous, but it is unsigtly and distracting, so
   this commit removes it by returning SSL_TLSEXT_ERR_OK instead.
   
   Signed-off-by: Ted Poole <tpoole@redhat.com>

   

   tedjpoole committed Jul 24, 2024
   Configuration menu

   • View commit details
   • Copy full SHA for 45d9d54
   • Browse repository at this point

   Copy the full SHA

   45d9d54 View commit details

   Browse the repository at this point in the history