Open
Conversation
This commit allows a dev to only exclude the root path ('/') from
the JWT token auth check but keep the auth check on other paths.
|
I like and need this exact case. Anything I can do to push this forward and help getting this merged? For example, I could make it more generic using a regex instead of Alternatively, a switch based on wether it is a string, or a regex: But then a tad more readable :) |
|
Anything we can do to help get this merged? |
berkes
added a commit
to berkes/rack-jwt
that referenced
this pull request
Nov 30, 2021
This is another go at eparreno#23, Where we make it a little more flexible by allowing either the old string version or a now newly introduced regxp. This is fully backwards compatible.
berkes
added a commit
to berkes/rack-jwt
that referenced
this pull request
Dec 1, 2021
This is another go at eparreno#23, Where we make it a little more flexible by allowing either the old string version or a now newly introduced regxp. This is fully backwards compatible.
|
We're having same issue as well - want to exclude root path, but |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey @eparreno 👋
Merging this PR will allow a dev to exclude the root path (
'/') without excluding all paths starting with a/from the JWT token auth check.This comes handy when we want to have a pretty landing/docs page mounted on
/and an JWT auth API that serves from other paths, i.e./users.