Remove add_ct argument
#104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nt to parameterise and not change dimensions of data
joshwlambert
added
documentation
Bisaloo
approved these changes
Apr 29, 2024
Co-authored-by: Hugo Gruson <10783929+Bisaloo@users.noreply.github.com>
Co-authored-by: Hugo Gruson <10783929+Bisaloo@users.noreply.github.com>
Bisaloo
reviewed
Apr 29, 2024
Co-authored-by: Hugo Gruson <10783929+Bisaloo@users.noreply.github.com>
This was referenced Apr 29, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses part of #41 by removing the
add_ctargument. The argument is removed fromsim_linelist()andsim_outbreak()and internal functions that these exported functions call.These changes move towards simplifying the function signatures of the exported simulation functions, as much as possible, as well as having consistent data output from exported functions. In this case the dimensions of the line list
<data.frame>fromsim_linelist()andsim_outbreak(). A bullet point has been added to the design principles vignette (design-principles.Rmd) to make this point.A new vignette has been added on data wrangling. This vignette will grow over time to include common data wrangling tasks required for line list and contact tracing data; providing tidyverse and base R examples.