Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing unused code #2 #946

Merged
merged 3 commits into from
Jan 5, 2024
Merged

Removing unused code #2 #946

merged 3 commits into from
Jan 5, 2024

Conversation

kushti
Copy link
Member

@kushti kushti commented Dec 30, 2023

In this PR:

  • complexity field removed from ErgoTree and serializers
  • unused methods removed from Helpers
  • some unused imports removed

@kushti kushti changed the base branch from develop to v5.0.14-RC January 4, 2024 00:25
@@ -31,7 +31,7 @@ class ReducingInterpreter(params: BlockchainParameters) extends ErgoLikeInterpre
* @return data object containing enough data to sign a transaction without Context.
*/
def reduce(env: ScriptEnv, ergoTree: ErgoTree, context: CTX): ReducedInputData = {
val initCost = ergoTree.complexity + context.initCost
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure why ergoTree.complexity was there, while in other reduction methods it was removed in 5.0

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is by mistake, it seems.

@kushti kushti requested a review from aslesarenko January 4, 2024 12:13
@aslesarenko aslesarenko merged commit efa68e7 into v5.0.14-RC Jan 5, 2024
4 checks passed
@aslesarenko aslesarenko deleted the unused-code branch January 10, 2024 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants