Fix SSH reverse search with CTRL+R

[jjcarstens]

group.erl now sends put_expand_no_trim when entering a history search. ssh_cli does not support that message and so when entering a search when SSH is the underlying driver, the expanded result would not be displayed even though the search functionality would still technically work.

This adds support for that put_expand_no_trim message when using SSH

I look through the tests and not entirely sure where I would put this. I'm happy to write that if there is any direction of how others might want it tested. In the meantime, this is my quick manual setup to test it works:

Start the Daemon

%% Create System host key
Priv = public_key:generate_key({rsa, 2048, 65537}).
PemEntry = public_key:pem_entry_encode(:"RSAPrivateKey", Priv).
Pem = public_key:pem_encode([PemEntry]).
ok = file:mkdir_p("/tmp/ssh"),
ok = file:write("/tmp/ssh/ssh_host_rsa_key", Pem).

%% Start SSH Daemon
Opts = [{system_dir, "/tmp/ssh"}, {pwdfun, fun (_, _, _, _) -> true end}],
application:ensure_all_started(ssh),
ssh:daemon(2222, Opts).

SSH (no password)

ssh localhost -p 2222
# CTRL+r to search history

[github-actions]

CT Test Results

       2 files       29 suites   57m 36s ⏱️
   453 tests    447 ✔️   5 💤 1 ❌
1 667 runs  1 639 ✔️ 27 💤 1 ❌

For more details on these failures, see this check.

Results for commit c205174.

♻️ This comment has been updated with latest results.

To speed up review, make sure that you have read Contributing to Erlang/OTP and that all checks pass.

See the TESTING and DEVELOPMENT HowTo guides for details about how to run test locally.

Artifacts

• Complete CT logs (Download Logs)
• HTML Documentation (Download HTML Docs)
• Windows Installer

// Erlang/OTP Github Action Bot

[IngelaAndin]

Thanks as it is vacation time it may take a little longer, but we will handle it.

[u3s]

I look through the tests and not entirely sure where I would put this. I'm happy to write that if there is any direction of how others might want it tested.

Can you check if some simple test could be developed around ssh_basic_SUITE:do_shell code?

[u3s]

I look through the tests and not entirely sure where I would put this. I'm happy to write that if there is any direction of how others might want it tested.

I will add a testcase to this PR. No need for you to spent time on it. Rough action plan:

1. merge ssh: support dumb terminals in ssh client #7627 including a base for test
2. rebase this PR
3. add a commit with a testcase dedicated for this PR

[jjcarstens]

Sorry! We seemed to have swapped vacation times and then I let this slip away from me until your recent comment 🤦🏼 Thanks for the help!

[u3s]

change of plans. we will merge both tests in this PR (removing the dependency towards #7627). I hope to merge your PR this week.