compiler destructive update: Patch every element of a list #8730
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The initial value tracker in the destructive update pass could sometimes fail to ensure that a term which was destructively updated was forced onto the heap as it did not have a way to easily follow list tails. This patch corrects that error by ensuring that if the first element of a literal list is forced onto the heap, all elements of the list will be forced onto the heap.
CT Test Results 2 files 324 suites 11m 29s ⏱️ Results for commit dadf00b. ♻️ This comment has been updated with latest results. To speed up review, make sure that you have read Contributing to Erlang/OTP and that all checks pass. See the TESTING and DEVELOPMENT HowTo guides for details about how to run test locally. Artifacts// Erlang/OTP Github Action Bot |
|
Thanks! Added to our daily builds for |
|
Merged manually to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The initial value tracker in the destructive update pass could sometimes fail to ensure that a term which was destructively updated was forced onto the heap as it did not have a way to easily follow list tails. This patch corrects that error by ensuring that if the first element of a literal list is forced onto the heap, all elements of the list will be forced onto the heap.