Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/display backlight control #131

Merged
merged 4 commits into from
Dec 4, 2023
Merged

Conversation

finger563
Copy link
Contributor

Description

  • Updated display and display_drivers to move backlight_pin and value into display instead of display_drivers
  • Add Led compoent as dependency to display component
  • Add Led object and initialize it accordingly in display component - backlight pin and value are added to both allocating and non-allocating configs
  • Expose set_brightness and get_brightness (range: [0, 1.0]) to the display component.

Motivation and Context

This is used in the esp-box-emu project for esp-cpp/esp-box-emu#40

How has this been tested?

  • Building the display_drivers example
  • Building and running within the new code for esp-box-emu

Screenshots (if appropriate, e.g. schematic, board, console logs, lab pictures):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update
  • Hardware (schematic, board, system design) change
  • Software change

Checklist:

  • My change requires a change to the documentation.
  • I have added / updated the documentation related to this change via either README or WIKI

Software

  • I have added tests to cover my changes.
  • I have updated the .github/workflows/build.yml file to add my new test to the automated cloud build github action.
  • All new and existing tests passed.
  • My code follows the code style of this project.

* Updated display and display_drivers to move backlight_pin and value into display instead of display_drivers
* Add Led compoent as dependency to display component
* Add Led object and initialize it accordingly in display component - backlight pin and value are added to both allocating and non-allocating configs
* Expose set_brightness and get_brightness (range: [0, 1.0]) to the display component.
@finger563 finger563 merged commit 46521df into main Dec 4, 2023
46 of 47 checks passed
@finger563 finger563 deleted the feature/display_backlight_control branch December 4, 2023 01:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant