esp_websocket: fix a crash when network anomaly (IDFGH-13461) #629
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
xutao seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
github-actions
bot
changed the title
david-cermak
approved these changes
Aug 16, 2024
|
Thank you for the update! I noticed that there are now two commits from different authors, and the pre-commit test didn’t pass. Could you please review our contribution guidelines and update this PR accordingly? Specifically, it would be great if you could:
If you’d prefer, just let me know -- I can take care of the chores and push your work in a separate PR, while still crediting your original commit. |
david-cermak
pushed a commit
to david-cermak/esp-protocols
that referenced
this pull request
Oct 31, 2024
When WiFi disconnects, `esp_websocket_client_task` continues polling `esp_transport_poll_read()` with a default 1-second timeout. If a timeout triggers `esp_websocket_client_abort_connection`, certain resources are released. However, if `esp_websocket_client_send_with_exact_opcode` is still blocked at this point, it will cause a crash when it times out and accesses the released handle. This fix prevents potential crashes by ensuring proper synchronization between abort and send functions. Merges: espressif#629
david-cermak
pushed a commit
to david-cermak/esp-protocols
that referenced
this pull request
Oct 31, 2024
When WiFi disconnects, `esp_websocket_client_task` continues polling `esp_transport_poll_read()` with a default 1-second timeout. If a timeout triggers `esp_websocket_client_abort_connection`, certain resources are released. However, if `esp_websocket_client_send_with_exact_opcode` is still blocked at this point, it will cause a crash when it times out and accesses the released handle. This fix prevents potential crashes by ensuring proper synchronization between abort and send functions. Merges: espressif#629
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when disconnect the wifi, the esp_websocket_client_task continue to called
esp_transport_poll_read to read, but the default the time is 1s, then the read had timeout will called esp_websocket_client_abort_connection to destory some handle, at this time, esp_websocket_client_send_with_exact_opcode still blocked.
when esp_websocket_client_send_with_exact_opcode had timeout, will trigger crash ， because handle(erro handle) already release