[websocket]: Prevent crash on network disconnect during send #684
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When WiFi disconnects, `esp_websocket_client_task` continues polling `esp_transport_poll_read()` with a default 1-second timeout. If a timeout triggers `esp_websocket_client_abort_connection`, certain resources are released. However, if `esp_websocket_client_send_with_exact_opcode` is still blocked at this point, it will cause a crash when it times out and accesses the released handle. This fix prevents potential crashes by ensuring proper synchronization between abort and send functions. Merges: espressif#629
1.3.0 Features - add events for begin/end thread (d7fa24b) - Make example to use certificate bundle (aecf6f8) - propagate esp_tls stack error and cert verify flags (234f579) - Add option to set and use cert_common_name in Websocket client (3a6720d) - adding support for `if_name` when using WSS transport (333a689) - allow updating reconnect timeout for retry backoffs (bd9f062) - allow using external tcp transport handle (83ea287) - adding support for `keep_alive_enable` when using WSS transport (c728eae) Bug Fixes - Prevent crash on network disconnect during send (a453ca1) - use proper interface to delete semaphore (991ac40) - Move client to different state when disconnecting (0d8f2a6) - fix of websocket host example (5ccc018) - don't get transport from the list if external transport is used (9d4d5d2) - Fix locking issues of `esp_websocket_client_send_with_exact_opcode` API (6393fcd)
david-cermak
force-pushed
the
fix/ws_disconnect_deadlock
branch
from
14d50d1 to
2bcfa45
Compare
euripedesrocha
approved these changes
Oct 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merges: #629
1.3.0
Features
if_namewhen using WSS transport (333a6893)keep_alive_enablewhen using WSS transport (c728eae5)Bug Fixes
esp_websocket_client_send_with_exact_opcodeAPI (6393fcd7)