Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Instrument distributed eigensolver with HDF5 #1016

Merged
merged 32 commits into from
May 2, 2024
Merged

Conversation

RMeli
Copy link
Member

@RMeli RMeli commented Oct 17, 2023

Since in previous discussion we decided that HDF5 is only used internally for debugging, I added HDF5 output for all stages of the distributed standard eigensolver. This expands the previous implementation, where only the input/output of the tridiagonal eigensolver is available.

The debug_ options are explicitly not added to operator<< in tune.cpp.

I need this for debugging, but please feel free to close the PR if it is not otherwise useful to have this functionality.

@RMeli
Copy link
Member Author

RMeli commented Oct 17, 2023

cscs-ci run

@RMeli
Copy link
Member Author

RMeli commented Dec 1, 2023

cscs-ci run

@RMeli
Copy link
Member Author

RMeli commented Dec 1, 2023

cscs-ci run

@RMeli
Copy link
Member Author

RMeli commented Dec 1, 2023

Waiting for #1057

@RMeli RMeli marked this pull request as ready for review December 4, 2023 08:26
@msimberg
Copy link
Collaborator

msimberg commented Dec 4, 2023

Revisit early next year.

@RMeli
Copy link
Member Author

RMeli commented Mar 26, 2024

cscs-ci run

@RMeli
Copy link
Member Author

RMeli commented Mar 26, 2024

I'm updating this PR because I need it. Please ignore.

(However, having it in master would be helpful for easier bisections if needed again in the future).

include/dlaf/eigensolver/band_to_tridiag/mc.h Outdated Show resolved Hide resolved
include/dlaf/eigensolver/eigensolver/impl.h Outdated Show resolved Hide resolved
include/dlaf/eigensolver/tridiag_solver/impl.h Outdated Show resolved Hide resolved
include/dlaf/eigensolver/band_to_tridiag/mc.h Outdated Show resolved Hide resolved
Co-authored-by: Mikael Simberg <mikael.simberg@iki.fi>
@RMeli
Copy link
Member Author

RMeli commented Apr 25, 2024

cscs-ci run

@RMeli
Copy link
Member Author

RMeli commented Apr 25, 2024

cscs-ci run

1 similar comment
@RMeli
Copy link
Member Author

RMeli commented Apr 25, 2024

cscs-ci run

@RMeli RMeli requested a review from msimberg April 26, 2024 07:27
Copy link
Collaborator

@msimberg msimberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only minor final comments, looks good to me otherwise. Thanks for making the changes!

include/dlaf/eigensolver/band_to_tridiag/mc.h Outdated Show resolved Hide resolved
include/dlaf/matrix/hdf5.h Show resolved Hide resolved
include/dlaf/eigensolver/eigensolver/impl.h Outdated Show resolved Hide resolved
include/dlaf/eigensolver/reduction_to_band/impl.h Outdated Show resolved Hide resolved
Co-authored-by: Mikael Simberg <mikael.simberg@iki.fi>
@RMeli
Copy link
Member Author

RMeli commented Apr 26, 2024

cscs-ci run

@rasolca
Copy link
Collaborator

rasolca commented May 2, 2024

cscs-ci run

@rasolca rasolca merged commit 38a3acd into eth-cscs:master May 2, 2024
4 checks passed
@RMeli RMeli deleted the hdf5 branch May 6, 2024 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants