TridiagSolver (dist): STEP3 reduce GEMM step computational cost #998
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
albestro
changed the base branch from
master
to
alby/trisolver-dist-opt-step2-multi
albestro
force-pushed
the
alby/trisolver-dist-opt-step2-multi
branch
from
a36baa8
to
05d4760
Compare
albestro
force-pushed
the
alby/trisolver-dist-opt-step3
branch
from
304c558
to
4abd8d7
Compare
albestro
commented
Oct 2, 2023
| ws.e0); | ||
| ex::start_detached( | ||
| ex::when_all(std::move(k_lc), std::move(n_udl), row_task_chain(), col_task_chain()) | | ||
| ex::transfer(dlaf::internal::getBackendScheduler<Backend::MC>()) | |
There was a problem hiding this comment.
note to self: since it is going to schedule work, it is better to give it high priority
albestro
added a commit
that referenced
this pull request
Oct 16, 2023
Develop: TridiagSolver (dist): STEP1 rank-independent sort of eigenvalues by column type for rank1 solver (#967) Develop: TridiagSolver (dist): STEP2 Make rank1 work just on local non-deflated eigenvectors (#996) Develop: TridiagSolver (dist): STEP2b Make rank1 work just on local non-deflated eigenvectors (multi-threaded) (#997) Develop: TridiagSolver (dist): STEP3 reduce GEMM step computational cost (#998)
albestro
force-pushed
the
alby/trisolver-dist-opt-step2-multi
branch
from
05d4760
to
fffad13
Compare
albestro
force-pushed
the
alby/trisolver-dist-opt-step3
branch
from
4abd8d7
to
62c1cbe
Compare
albestro
force-pushed
the
alby/trisolver-dist-opt-step2-multi
branch
from
fffad13
to
a538c2e
Compare
albestro
force-pushed
the
alby/trisolver-dist-opt-step3
branch
2 times, most recently
from
55cbba0
to
887cc16
Compare
2 tasks
albestro
force-pushed
the
alby/trisolver-dist-opt-step3
branch
from
887cc16
to
8817224
Compare
albestro
force-pushed
the
alby/trisolver-dist-opt-step2-multi
branch
from
6c4a7b5
to
ec9ebf6
Compare
4 tasks
Base automatically changed from
alby/trisolver-dist-opt-step2-multi
to
master
December 12, 2023 12:42
albestro
force-pushed
the
alby/trisolver-dist-opt-step3
branch
from
8817224
to
a824d40
Compare
rasolca
approved these changes
Dec 12, 2023
msimberg
approved these changes
Dec 12, 2023
|
cscs-ci run |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #916
This PR is the last step of the Distributed Tridiagonal Solver optimization in order to reduce GEMM cost.
After all the preliminary work to make the tridiagonal work with a well-shaped matrix of eigenvectors, now it is possible to exploit that to actually reduce the GEMM cost.
Main changes: