Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update selections endpoint description #368

Merged
merged 5 commits into from
Nov 5, 2023

Conversation

xenowits
Copy link
Contributor

Update endpoint descriptions for the following selections endpoints:

  • /eth/v1/validator/beacon_committee_selections
  • /eth/v1/validator/sync_committee_selections

This PR updates selection endpoint descriptions to explicitly state when to call these endpoints:

  • For sync committee selections, validator clients must query this endpoint at the start of each slot in the sync committee period.
  • For beacon committee selections, validator clients must query this endpoint at the start of each epoch for attester duties in the current and next epochs.

Note: This change eliminates confusion among client teams implementing these endpoints on when to query the selection endpoints.

xenowits added 3 commits July 5, 2023 10:47
* edit api descriptions

* cleanup

* edit message
* update to mention lookahead epochs

* clarify current and lookahead epochs

* review comments
Copy link
Contributor

@OisinKyne OisinKyne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we add my suggestion to make it apparent it doesn't have to be default behaviour, only when the VC is part of a cluster?

apis/validator/beacon_committee_selections.yaml Outdated Show resolved Hide resolved
apis/validator/sync_committee_selections.yaml Outdated Show resolved Hide resolved
xenowits and others added 2 commits October 27, 2023 15:35
Co-authored-by: Oisín Kyne <4981644+OisinKyne@users.noreply.github.com>
Co-authored-by: Oisín Kyne <4981644+OisinKyne@users.noreply.github.com>
Copy link
Collaborator

@rolfyone rolfyone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rolfyone rolfyone merged commit 4c080a9 into ethereum:master Nov 5, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants