evmmax: Initial implementation of EVMMAX instructions (EIP-6690) #742
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rodiazet
force-pushed
the
evmmax-intructions
branch
from
d33d0ea
to
b4c0208
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #742 +/- ##
==========================================
- Coverage 97.91% 97.83% -0.08%
==========================================
Files 110 112 +2
Lines 10580 10946 +366
==========================================
+ Hits 10359 10709 +350
- Misses 221 237 +16
Flags with carried forward coverage won't be shown. Click here to find out more.
|
rodiazet
force-pushed
the
evmmax-intructions
branch
27 times, most recently
from
7d36325
to
3f42dd5
Compare
rodiazet
force-pushed
the
evmmax-intructions
branch
from
3f42dd5
to
9e876e2
Compare
rodiazet
force-pushed
the
evmmax-intructions
branch
3 times, most recently
from
89aa150
to
ed0056e
Compare
rodiazet
force-pushed
the
evmmax-intructions
branch
from
ed0056e
to
67808c1
Compare
chfast
changed the title
chfast
reviewed
Jan 8, 2024
lib/evmmax/evmmax.cpp
Outdated
|
|
||
| [[nodiscard]] bool addmodx(size_t dst_idx, size_t x_idx, size_t y_idx) noexcept override | ||
| { | ||
| if (dst_idx < values.size() && x_idx < values.size() && y_idx < values.size()) |
There was a problem hiding this comment.
I think we should assume the indexes are valid (because they are going to be validated by EOF). Debug asserts are fine obviously.
rodiazet
force-pushed
the
evmmax-intructions
branch
2 times, most recently
from
e55c458
to
e156a5a
Compare
rodiazet
changed the title
rodiazet
force-pushed
the
evmmax-intructions
branch
3 times, most recently
from
92b00a1
to
4136a08
Compare
test: Omit new opcodes with immediate params in unit tests
Add new instruction implementation signature `code_iterator (*instr_fn)(StackTop, ExecutionState&, code_iterator, int64_t&)`
rodiazet
force-pushed
the
evmmax-intructions
branch
3 times, most recently
from
72ba52f
to
81eaef0
Compare
rodiazet
force-pushed
the
evmmax-intructions
branch
from
81eaef0
to
ab38a8d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on EIP-6690
code_iterator (*instr_fn)(StackTop, ExecutionState&, code_iterator, int64_t&)EVMMAXstate to evm execution state interfaceEVMMAXmodulus interface and implementation for differentUintTtypes