fix: correct unit tests in hyper-optimised-telemetry exercise#1796
Merged
ErikSchierboom merged 2 commits intoexercism:mainfrom Nov 3, 2021
kaelon141:hotfix/hyper-optimised-telemetry-unit-tests
Merged
fix: correct unit tests in hyper-optimised-telemetry exercise#1796ErikSchierboom merged 2 commits intoexercism:mainfrom kaelon141:hotfix/hyper-optimised-telemetry-unit-tests
ErikSchierboom merged 2 commits intoexercism:mainfrom
kaelon141:hotfix/hyper-optimised-telemetry-unit-tests
Conversation
rosalina-ha
approved these changes
Oct 29, 2021
Member
|
@j141 Could you also update the exemplar implementation (.meta/Exemplar.cs)? That should fix CI. |
Author
|
@ErikSchierboom Whoops, i somehow missed the existence of that Exemplar.cs. I've updated it to match the changes to the unit tests now. |
ErikSchierboom
approved these changes
Nov 3, 2021
Member
ErikSchierboom
left a comment
ErikSchierboom
left a comment
There was a problem hiding this comment.
This makes much more sense now!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes two unit tests on the hyper-optimised-telemetry exercise that wrongly assume
0andInt16.MaxValue(32767) should be encoded into signed shorts, rather than unsigned shorts as specified in the exercise instructions.Directly targets issue #1795 and #1621 (The latter having been closed, though it reports the same problem)
This PR is incompatible with PR #1756, as the author of that PR aims to change the instructions to be in line with how the unit tests have been set up, while this PR aims to do the exact inverse by changing the unit tests to match the instructions instead.