Skip to content

fix: correct unit tests in hyper-optimised-telemetry exercise #1796

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ErikSchierboom merged 2 commits into from
Nov 3, 2021
Merged

fix: correct unit tests in hyper-optimised-telemetry exercise #1796

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0fad8b7
fix: correct unit tests in hyper-optimised-telemetry exercise
Oct 29, 2021
720458e
fix: update Exemplar.cs to match new unit tests
Nov 2, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 1 addition & 7 deletions exercises/concept/hyper-optimized-telemetry/.meta/Exemplar.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,15 +25,9 @@ public static byte[] ToBuffer(long reading)
bytes = BitConverter.GetBytes((int)reading);
bytes.CopyTo(allBytes, 1);
}
else if (reading > Int16.MaxValue)
{
allBytes[0] = 0x2;
bytes = BitConverter.GetBytes((ushort)reading);
bytes.CopyTo(allBytes, 1);
}
else if (reading >= 0)
{
allBytes[0] = 0xfe;
allBytes[0] = 0x2;
bytes = BitConverter.GetBytes((ushort)reading);
bytes.CopyTo(allBytes, 1);
}
Expand Down
4 changes: 2 additions & 2 deletions exercises/concept/hyper-optimized-telemetry/HyperOptimizedTelemetryTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,15 +73,15 @@ public void ToBuffer_lower_ushort()
public void ToBuffer_upper_short()
{
var bytes = TelemetryBuffer.ToBuffer(Int16.MaxValue);
Assert.Equal(new byte[] { 0xfe, 0xff, 0x7f, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0 }, bytes);
Assert.Equal(new byte[] { 0x2, 0xff, 0x7f, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0 }, bytes);
}

[Fact]
[Task(1)]
public void ToBuffer_Zero()
{
var bytes = TelemetryBuffer.ToBuffer(0);
Assert.Equal(new byte[] { 0xfe, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0 }, bytes);
Assert.Equal(new byte[] { 0x2, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0 }, bytes);
}

[Fact]
Expand Down