3.x/features #1
Closed
3.x/features #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Don't you think this needs versioning? This is a more used task, and I would like to have versioning here, especially given your reference of "3.x" |
|
Yes. How do we manage versions? |
|
Ah let's get this guy hooked up to Circle CI! For versions I say we should have the merge (that deploys the container with the experiment) have a version corresponding to the commit. Let me turn on CircleCI and see what happens... |
vsoch
reviewed
Aug 24, 2018
vsoch
reviewed
Aug 24, 2018
|
@earcanal I'm going to do the same as I did for the breath counting and start with this branch and make a crapton of changes for the CI - sound good? |
|
okay let's pick this up in #2 |
vsoch
reviewed
Sep 5, 2018
Closed
|
Please move work to expfactory-experiments/attention-network-test#1, this is the wrong task to PR to, closing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This one probably does need either code review prior to merge, and/or an way of maintaining multiple versions.