-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Earcanal 3.x/features #2
Conversation
Wow almost perfect first shot! The only things I see are:
|
I'd like to keep the package named Once done, I think we're good. |
We need to decide on a naming scheme and stick with It. |
I'm proposing |
Then why is this PR to "attention-network-task" ? |
Please move work to here, this is a different task, closing. expfactory-experiments/attention-network-test#1 |
@earcanal this PR we will use to continue working on the updates to this package! I've made some changes to get us started, and when you have the bandwidth you can give a shot at looking at (the actual) tests. Likely the bugs are what were there before.