FetchRecipeDeatil의 비즈니스 로직을 테스트 해보았습니다. #16
Conversation
| extension Recipe { | ||
|
|
||
| static func dummy() -> Recipe { | ||
| .init(id: 1, type: .coffee, name: "", description: "", writer: .init(id: 1, profileImage: "", nickname: "", createdAt: Date()), imageUrls: [], isLikedByCurrentUser: false, likeCount: 0, createdAt: Date()) |
There was a problem hiding this comment.
라인수가 길어지는 경우, 줄바꿈 해주세요.
또 이런 init 단계에 파라미터를 넣어주는 코드 같은 경우에는 언제든지 확장되어 길어질 수 있으니 줄바꿈을 하면서 작성하는게 좋아요. 앞으로 줄바꿈 같은 코드 스타일 코멘트는 줄여나가도록 더 신경써주시면 좋을 것 같아요.
| class FetchRecipeDetailUseCaseMock: FetchRecipeDetailUseCase { | ||
| var executeCallCount: Int = 0 | ||
| var executeStub: Single<Result<Recipe, Error>> = .just(.failure(NSError())) | ||
| func execute(recipeID: Int) -> Single<Result<Recipe, Error>> { | ||
| executeCallCount += 1 | ||
| return executeStub | ||
| } | ||
| } | ||
|
|
||
| class RecipeDetailInteractorDelegateMock: RecipeDetailInteractorDelegate { | ||
| var fetchedCallCount: Int = 0 | ||
| var fetchedRecipeResult: Result<Recipe, Error>? | ||
| func fetchedRecipe(result: Result<Recipe, Error>) { | ||
| fetchedCallCount += 1 | ||
| fetchedRecipeResult = result |
There was a problem hiding this comment.
얘네는 final class로 선언하시지 않은 이유가 있나요?
There was a problem hiding this comment.
final 처리가 아직 익숙하지 않아서 놓친거 같습니다
좀 더 신경 쓰도록 하겠습니다
[415e9a4] 수정했습니다.
| override func tearDownWithError() throws { | ||
| // Put teardown code here. This method is called after the invocation of each test method in the class. | ||
| } | ||
| } |
|
|
||
| extension RecipeDetailInteractorTests { | ||
|
|
||
| func test_화면이_로드될때_FetchRecipeDetailUsecase를_실행합니다() { |
There was a problem hiding this comment.
FetchRecipeDetailUseCase를 실행하는게 아니라 FetchRecipeDetailUseCase의 execute를 호출하는거 아닐까요?
There was a problem hiding this comment.
[0cc06c1] 네이밍 수정했습니다
| func test_FetchRecipeDetailUsecase의_성공응답이오면_Delegate로_성공을_전달합니다() { | ||
| // given | ||
| let interactor = createInteractor() | ||
| let recipe = Recipe.dummy() |
| XCTAssertEqual(self.fetchRecipeDetailUsecase.executeCallCount, 1) | ||
| XCTAssertEqual(self.delegate.fetchedCallCount, 1) | ||
|
|
||
| if case .success(let fetchedRecipe)? = self.delegate.fetchedRecipeResult { |
| XCTAssertEqual(self.fetchRecipeDetailUsecase.executeCallCount, 1) | ||
| XCTAssertEqual(self.delegate.fetchedCallCount, 1) | ||
|
|
||
| if case .failure(let fetchedError as NSError) = self.delegate.fetchedRecipeResult { |
| var fetchRecipeDetailRepository: FetchRecipeRepositoryMock! | ||
| var disposeBag: DisposeBag! | ||
|
|
||
| class FetchRecipeRepositoryMock: RecipeDetailRepository { |
| } | ||
|
|
||
| func createUseCase() -> FetchRecipeDetailUseCase { | ||
| let usecase = FetchRecipeDetailUseCaseImpl(repository: fetchRecipeDetailRepository) |
| override func tearDownWithError() throws { | ||
| } |
There was a problem hiding this comment.
[18959c6] 제거 했습니다
|
|
||
| extension FetchRecipeDetailUseCaseTests { | ||
|
|
||
| func test_execute를_호출하면_1번_RecipeDetailRepository의_fetchRecipeDetail을_호출합니다(){ |
There was a problem hiding this comment.
이 테스트 코드에서 1번 호출하는건 검증하고 있지 않은 것 같네요?
여러번 호출해도 1번만 calleCount가 올라가는지 검증해야 테스트 케이스와 맞겠네요.
| .subscribe(onSuccess: { result in | ||
| if case .failure(let receivedError as NSError) = result { | ||
| // Then | ||
|
|
||
| XCTAssertEqual(receivedError.domain, error.domain) | ||
| XCTAssertEqual(receivedError.code, error.code) | ||
| expectation.fulfill() |
There was a problem hiding this comment.
질문) onSuccess 내부에서 failure 검증이 성공했나요?
There was a problem hiding this comment.
이런식으로 테스트 결과가 나왔는데 검증이 성공된거 아닌가요?
There was a problem hiding this comment.
execute에서 .success로 failure를 전달하나보네요
|
FetchRecipeDetailUseCaseTests를 생성하였습니다
RecipeDetailInteractorTests를 생성하였습니다