Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FetchRecipeDeatil의 비즈니스 로직을 테스트 해보았습니다. #16

Merged
merged 11 commits into from
Jul 23, 2024
Merged

FetchRecipeDeatil의 비즈니스 로직을 테스트 해보았습니다. #16

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
5adae12
Fix: Recipe에 dummy 생성 메서드 추가
GeonH0 Jul 21, 2024
0518ea3
Feat: RecipeDetailInteractorTests 정의
GeonH0 Jul 20, 2024
93bd467
Feat: FetchRecipeDetailUseCaseTests 정의
GeonH0 Jul 20, 2024
d7ab88c
Fix: dummy 줄바꿈 적용
GeonH0 Jul 21, 2024
415e9a4
Fix: Mock 객체 final 처리
GeonH0 Jul 22, 2024
18959c6
Fix: 불필요한 메서드 제거
GeonH0 Jul 22, 2024
80597bd
Fix: dummyRecipe로 네이밍 수정
GeonH0 Jul 22, 2024
7e579b8
Fix: self.delegate.fetchedRecipeResult에서 self 제거
GeonH0 Jul 22, 2024
d0d27b0
Fix: FetchRecipeDetailUseCaseImpl 개행
GeonH0 Jul 22, 2024
0cc06c1
Fix: test 네이밍 수정
GeonH0 Jul 22, 2024
61854b3
Fix: 테스트케이스 수정
GeonH0 Jul 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions HomeCafeRecipes/HomeCafeRecipes/Domain/Entities/Recipe.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,3 +18,10 @@ struct Recipe {
let likeCount: Int
let createdAt: Date
}

extension Recipe {

static func dummy() -> Recipe {
.init(id: 1, type: .coffee, name: "", description: "", writer: .init(id: 1, profileImage: "", nickname: "", createdAt: Date()), imageUrls: [], isLikedByCurrentUser: false, likeCount: 0, createdAt: Date())
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

라인수가 길어지는 경우, 줄바꿈 해주세요.
또 이런 init 단계에 파라미터를 넣어주는 코드 같은 경우에는 언제든지 확장되어 길어질 수 있으니 줄바꿈을 하면서 작성하는게 좋아요. 앞으로 줄바꿈 같은 코드 스타일 코멘트는 줄여나가도록 더 신경써주시면 좋을 것 같아요.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[d7ab88c] 수정했습니다

}
}