Check for system bars apperance on newer SDKs

[Abbondanzo]

Summary

As identified in #34350, modals do not honor the system's status bar colors because they may not be set by the deprecated systemUiVisibility flags. Unless android:windowLightStatusBar is set to true, the default flag is a zero-integer (a.k.a. "dark mode", where the icons show as white). Since the StatusBar component is using the new setSystemBarsAppearance API, the ModalHost should also infer its status bar settings from the same API. Some additional context can be found in my comment here.

Changelog

[Android] [Fixed] - Fixed an issue on Android API 31+ where modals would turn status bar icons white by default

Test Plan

• On a screen with the StatusBar bar style set to dark-content, the modal also uses white icons
• On a screen with the StatusBar bar style set to light-content, the modal also uses black icons

Preview

Here, I change the barStyle from light-content to dark-content and demonstrate that the proper attributes are retained. The "Before" is a recording from main and the "After" is this branch. Notice how in "Before", the status bar is always turning the icons white when the modal opens.

Before	After

Other considerations

There's some argument towards removing this check entirely--the status bar appearance should be derived from the theming and/or the parent activity's settings, thereby removing the need to apply separate styling

[analysis-bot]

Platform	Engine	Arch	Size (bytes)	Diff
ios	-	universal	n/a	--

Base commit: 1fc27c4
Branch: main

[facebook-github-bot]

Hi @Abbondanzo!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

[facebook-github-bot]

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

[analysis-bot]

Platform	Engine	Arch	Size (bytes)	Diff
android	hermes	arm64-v8a	7,746,543	-21,951
android	hermes	armeabi-v7a	7,148,477	-20,971
android	hermes	x86	8,057,618	-24,021
android	hermes	x86_64	8,028,672	-24,459
android	jsc	arm64-v8a	9,608,219	-21,163
android	jsc	armeabi-v7a	8,373,462	-20,346
android	jsc	x86	9,555,483	-23,318
android	jsc	x86_64	10,148,012	-23,882

Base commit: 1fc27c4
Branch: main

[facebook-github-bot]

@makovkastar has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

[Abbondanzo]

The StatusBarModule makes this same if/else check, so reimplementing it here:

react-native/ReactAndroid/src/main/java/com/facebook/react/modules/statusbar/StatusBarModule.java

Lines 193 to 204 in c4f9556

	if (Build.VERSION.SDK_INT > Build.VERSION_CODES.R) {
	WindowInsetsController insetsController = activity.getWindow().getInsetsController();
	if ("dark-content".equals(style)) {
	// dark-content means dark icons on a light status bar
	insetsController.setSystemBarsAppearance(
	WindowInsetsController.APPEARANCE_LIGHT_STATUS_BARS,
	WindowInsetsController.APPEARANCE_LIGHT_STATUS_BARS);
	} else {
	insetsController.setSystemBarsAppearance(
	0, WindowInsetsController.APPEARANCE_LIGHT_STATUS_BARS);
	}
	} else if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.M) {

[react-native-bot]

This pull request was successfully merged by @Abbondanzo in 5c5220a.

^{When will my fix make it into a release? | Upcoming Releases}