Add Raw Data Size Stat to Nimble Files #74
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D60534808 |
|
This pull request was exported from Phabricator. Differential Revision: D60534808 |
phoenixawe
added a commit
to phoenixawe/nimble
that referenced
this pull request
Aug 20, 2024
Summary: Pull Request resolved: facebookincubator#74 # Context Knowing the size of the raw data being written is useful for identifying the cause of changes to file sizes after compressing and encoding when writing to files. # Changes - Adding the optional Stats section to Tablet - Calculating the raw data size in bytes via running sum of memory used right before encoding and flushing, and writing this to tablet. - Unit testing and fuzz testing # Important Notes - In `VeloxWriter.cpp` we have special handling for chunked null streams, which is why `materialize` is called before one of the rawSize stat calculations and not the other. - `rawStripeSize` name updated for clarity and value is now as the name implies, which I can guarantee is correct because it calculated in the same way as raw file size. - Some investigation determined that rawStripeSize in stripe flush metrics is also currently not used anywhere. Differential Revision: D60534808
phoenixawe
force-pushed
the
export-D60534808
branch
from
5a4891e
to
1c71502
Compare
|
This pull request was exported from Phabricator. Differential Revision: D60534808 |
phoenixawe
added a commit
to phoenixawe/nimble
that referenced
this pull request
Aug 20, 2024
Summary: Pull Request resolved: facebookincubator#74 # Context Knowing the size of the raw data being written is useful for identifying the cause of changes to file sizes after compressing and encoding when writing to files. # Changes - Adding the optional Stats section to Tablet - `VeloxWriter.cpp`: Calculating the raw data size in bytes via running sum of memory used right before encoding and flushing, and writing this to tablet. - `FieldWriter.h`: Added `rawSize()` virtual function to handle string and nullable cases. - Unit testing and fuzz testing # Important Notes - In `VeloxWriter.cpp` we have special handling for chunked null streams, which is why `materialize` is called before one of the rawSize stat calculations and not the other. - `rawStripeSize` name updated for clarity and value is now as the name implies, which I can guarantee is correct because it calculated in the same way as raw file size. - Some investigation determined that rawStripeSize in stripe flush metrics is also currently not used anywhere. Differential Revision: D60534808
phoenixawe
force-pushed
the
export-D60534808
branch
from
1c71502
to
fa51648
Compare
|
This pull request was exported from Phabricator. Differential Revision: D60534808 |
phoenixawe
added a commit
to phoenixawe/nimble
that referenced
this pull request
Aug 20, 2024
Summary: Pull Request resolved: facebookincubator#74 # Context Knowing the size of the raw data being written is useful for identifying the cause of changes to file sizes after compressing and encoding when writing to files. # Changes - Adding the optional Stats section to Tablet - `VeloxWriter.cpp`: Calculating the raw data size in bytes via running sum of memory used right before encoding and flushing, and writing this to tablet. - `FieldWriter.h`: Added `rawSize()` virtual function to handle string and nullable cases. - Unit testing and fuzz testing # Important Notes - In `VeloxWriter.cpp` we have special handling for chunked null streams, which is why `materialize` is called before one of the rawSize stat calculations and not the other. - `rawStripeSize` name updated for clarity and value is now as the name implies, which I can guarantee is correct because it calculated in the same way as raw file size. - Some investigation determined that rawStripeSize in stripe flush metrics is also currently not used anywhere. Differential Revision: D60534808
phoenixawe
force-pushed
the
export-D60534808
branch
from
fa51648
to
0f6d768
Compare
|
This pull request was exported from Phabricator. Differential Revision: D60534808 |
phoenixawe
added a commit
to phoenixawe/nimble
that referenced
this pull request
Aug 21, 2024
Summary: Pull Request resolved: facebookincubator#74 # Context Knowing the size of the raw data being written is useful for identifying the cause of changes to file sizes after compressing and encoding when writing to files. # Changes - Adding the optional Stats section to Tablet - `VeloxWriter.cpp`: Calculating the raw data size in bytes via running sum of memory used right before encoding and flushing, and writing this to tablet. - `FieldWriter.h`: Added `rawSize()` virtual function to handle string and nullable cases. - Unit testing and fuzz testing # Important Notes - In `VeloxWriter.cpp` we have special handling for chunked null streams, which is why `materialize` is called before one of the rawSize stat calculations and not the other. - `rawStripeSize` name updated for clarity and value is now as the name implies, which I can guarantee is correct because it calculated in the same way as raw file size. - Some investigation determined that rawStripeSize in stripe flush metrics is also currently not used anywhere. Differential Revision: D60534808
phoenixawe
force-pushed
the
export-D60534808
branch
from
0f6d768
to
ce44599
Compare
|
This pull request was exported from Phabricator. Differential Revision: D60534808 |
phoenixawe
force-pushed
the
export-D60534808
branch
from
ce44599
to
a234e45
Compare
phoenixawe
added a commit
to phoenixawe/nimble
that referenced
this pull request
Aug 22, 2024
Summary: Pull Request resolved: facebookincubator#74 # Context Knowing the size of the raw data being written is useful for identifying the cause of changes to file sizes after compressing and encoding when writing to files. # Changes - Adding the optional Stats section to Tablet - `VeloxWriter.cpp`: Calculating the raw data size in bytes via running sum of memory used right before encoding and flushing, and writing this to tablet. - `FieldWriter.h`: Added `rawSize()` virtual function to handle string and nullable cases. - Unit testing and fuzz testing # Important Notes - In `VeloxWriter.cpp` we have special handling for chunked null streams, which is why `materialize` is called before one of the rawSize stat calculations and not the other. - `rawStripeSize` name updated for clarity and value is now as the name implies, which I can guarantee is correct because it calculated in the same way as raw file size. - Some investigation determined that rawStripeSize in stripe flush metrics is also currently not used anywhere. Differential Revision: D60534808
|
This pull request was exported from Phabricator. Differential Revision: D60534808 |
phoenixawe
added a commit
to phoenixawe/nimble
that referenced
this pull request
Aug 22, 2024
Summary: Pull Request resolved: facebookincubator#74 # Context Knowing the size of the raw data being written is useful for identifying the cause of changes to file sizes after compressing and encoding when writing to files. # Changes - Adding the optional Stats section to Tablet - `VeloxWriter.cpp`: Calculating the raw data size in bytes via running sum of memory used right before encoding and flushing, and writing this to tablet. - `FieldWriter.h`: Added `rawSize()` virtual function to handle string and nullable cases. - Unit testing and fuzz testing # Important Notes - In `VeloxWriter.cpp` we have special handling for chunked null streams, which is why `materialize` is called before one of the rawSize stat calculations and not the other. - `rawStripeSize` name updated for clarity and value is now as the name implies, which I can guarantee is correct because it calculated in the same way as raw file size. - Some investigation determined that rawStripeSize in stripe flush metrics is also currently not used anywhere. Differential Revision: D60534808
phoenixawe
force-pushed
the
export-D60534808
branch
from
a234e45
to
79c2944
Compare
|
This pull request was exported from Phabricator. Differential Revision: D60534808 |
phoenixawe
added a commit
to phoenixawe/nimble
that referenced
this pull request
Aug 22, 2024
Summary: Pull Request resolved: facebookincubator#74 # Context Knowing the size of the raw data being written is useful for identifying the cause of changes to file sizes after compressing and encoding when writing to files. # Changes - Adding the optional Stats section to Tablet - `VeloxWriter.cpp`: Calculating the raw data size in bytes via running sum of memory used right before encoding and flushing, and writing this to tablet. - `FieldWriter.h`: Added `rawSize()` virtual function to handle string and nullable cases. - Unit testing and fuzz testing # Important Notes - In `VeloxWriter.cpp` we have special handling for chunked null streams, which is why `materialize` is called before one of the rawSize stat calculations and not the other. - `rawStripeSize` name updated for clarity and value is now as the name implies, which I can guarantee is correct because it calculated in the same way as raw file size. - Some investigation determined that rawStripeSize in stripe flush metrics is also currently not used anywhere. Differential Revision: D60534808
phoenixawe
force-pushed
the
export-D60534808
branch
from
79c2944
to
3f6df76
Compare
|
This pull request was exported from Phabricator. Differential Revision: D60534808 |
phoenixawe
added a commit
to phoenixawe/nimble
that referenced
this pull request
Aug 23, 2024
Summary: Pull Request resolved: facebookincubator#74 # Context Knowing the size of the raw data being written is useful for identifying the cause of changes to file sizes after compressing and encoding when writing to files. # Changes - Adding the optional Stats section to Tablet - `VeloxWriter.cpp`: Calculating the raw data size in bytes via running sum of memory used right before encoding and flushing, and writing this to tablet. - `FieldWriter.h`: Added `rawSize()` virtual function to handle string and nullable cases. - Unit testing and fuzz testing # Important Notes - In `VeloxWriter.cpp` we have special handling for chunked null streams, which is why `materialize` is called before one of the rawSize stat calculations and not the other. - `rawStripeSize` name updated for clarity and value is now as the name implies, which I can guarantee is correct because it calculated in the same way as raw file size. - Some investigation determined that rawStripeSize in stripe flush metrics is also currently not used anywhere. Differential Revision: D60534808
phoenixawe
force-pushed
the
export-D60534808
branch
from
3f6df76
to
7e8e3eb
Compare
|
This pull request was exported from Phabricator. Differential Revision: D60534808 |
phoenixawe
added a commit
to phoenixawe/nimble
that referenced
this pull request
Aug 23, 2024
Summary: Pull Request resolved: facebookincubator#74 # Context Knowing the size of the raw data being written is useful for identifying the cause of changes to file sizes after compressing and encoding when writing to files. # Changes - Adding the optional Stats section to Tablet - `VeloxWriter.cpp`: Calculating the raw data size in bytes via running sum of memory used right before encoding and flushing, and writing this to tablet. - `FieldWriter.h`: Added `rawSize()` virtual function to handle string and nullable cases. - Unit testing and fuzz testing # Important Notes - In `VeloxWriter.cpp` we have special handling for chunked null streams, which is why `materialize` is called before one of the rawSize stat calculations and not the other. - `rawStripeSize` name updated for clarity and value is now as the name implies, which I can guarantee is correct because it calculated in the same way as raw file size. - Some investigation determined that rawStripeSize in stripe flush metrics is also currently not used anywhere. Differential Revision: D60534808
phoenixawe
force-pushed
the
export-D60534808
branch
from
7e8e3eb
to
b5f4129
Compare
phoenixawe
added a commit
to phoenixawe/nimble
that referenced
this pull request
Sep 19, 2024
Summary: Pull Request resolved: facebookincubator#74 # Context Knowing the size of the raw data being written is useful for identifying the cause of changes to file sizes after compressing and encoding when writing to files. The implementation calculating the logical raw data size for the file will be implemented in a followup task. # Changes - Adding the optional Stats section to Tablet - `VeloxWriter.cpp`: Calculating the raw data size in bytes via running sum of memory used right before encoding and flushing - temporarily writing 0 to rawSize to maintain the status quo while the final calculation is not yet implemented. - `FieldWriter.h`: Added `rawSize()` virtual function to handle string and nullable cases. # Important Notes - In `VeloxWriter.cpp` we have special handling for chunked null streams, which is why `materialize` is called before one of the rawSize stat calculations and not the other. - `rawStripeSize` name updated for clarity. - Some investigation determined that rawStripeSize in stripe flush metrics is also currently not used anywhere. Differential Revision: D60534808
phoenixawe
force-pushed
the
export-D60534808
branch
from
0df7136
to
26d596f
Compare
|
This pull request was exported from Phabricator. Differential Revision: D60534808 |
phoenixawe
added a commit
to phoenixawe/nimble
that referenced
this pull request
Sep 19, 2024
Summary: Pull Request resolved: facebookincubator#74 # Context Knowing the size of the raw data being written is useful for identifying the cause of changes to file sizes after compressing and encoding when writing to files. The implementation calculating the logical raw data size for the file will be implemented in a followup task. # Changes - Adding the optional Stats section to Tablet - `VeloxWriter.cpp`: Calculating the raw data size in bytes via running sum of memory used right before encoding and flushing - temporarily writing 0 to rawSize to maintain the status quo while the final calculation is not yet implemented. - `FieldWriter.h`: Added `rawSize()` virtual function to handle string and nullable cases. # Important Notes - In `VeloxWriter.cpp` we have special handling for chunked null streams, which is why `materialize` is called before one of the rawSize stat calculations and not the other. - `rawStripeSize` name updated for clarity. - Some investigation determined that rawStripeSize in stripe flush metrics is also currently not used anywhere. Differential Revision: D60534808
phoenixawe
force-pushed
the
export-D60534808
branch
from
26d596f
to
fc2a7d1
Compare
|
This pull request was exported from Phabricator. Differential Revision: D60534808 |
phoenixawe
added a commit
to phoenixawe/nimble
that referenced
this pull request
Sep 19, 2024
Summary: Pull Request resolved: facebookincubator#74 # Context Knowing the size of the raw data being written is useful for identifying the cause of changes to file sizes after compressing and encoding when writing to files. The implementation calculating the logical raw data size for the file will be implemented in a followup task. # Changes - Adding the optional Stats section to Tablet - `VeloxWriter.cpp`: Calculating the raw data size in bytes via running sum of memory used right before encoding and flushing - temporarily writing 0 to rawSize to maintain the status quo while the final calculation is not yet implemented. - `FieldWriter.h`: Added `rawSize()` virtual function to handle string and nullable cases. # Important Notes - In `VeloxWriter.cpp` we have special handling for chunked null streams, which is why `materialize` is called before one of the rawSize stat calculations and not the other. - `rawStripeSize` name updated for clarity. - Some investigation determined that rawStripeSize in stripe flush metrics is also currently not used anywhere. Differential Revision: D60534808
phoenixawe
force-pushed
the
export-D60534808
branch
from
fc2a7d1
to
b9da7db
Compare
phoenixawe
added a commit
to phoenixawe/nimble
that referenced
this pull request
Sep 19, 2024
Summary: Pull Request resolved: facebookincubator#74 # Context Knowing the size of the raw data being written is useful for identifying the cause of changes to file sizes after compressing and encoding when writing to files. The implementation calculating the logical raw data size for the file will be implemented in a followup task. # Changes - Adding the optional Stats section to Tablet - `VeloxWriter.cpp`: Calculating the raw data size in bytes via running sum of memory used right before encoding and flushing - temporarily writing 0 to rawSize to maintain the status quo while the final calculation is not yet implemented. - `FieldWriter.h`: Added `rawSize()` virtual function to handle string and nullable cases. # Important Notes - In `VeloxWriter.cpp` we have special handling for chunked null streams, which is why `materialize` is called before one of the rawSize stat calculations and not the other. - `rawStripeSize` name updated for clarity. - Some investigation determined that rawStripeSize in stripe flush metrics is also currently not used anywhere. Differential Revision: D60534808
|
This pull request was exported from Phabricator. Differential Revision: D60534808 |
phoenixawe
added a commit
to phoenixawe/nimble
that referenced
this pull request
Sep 19, 2024
Summary: Pull Request resolved: facebookincubator#74 # Context Knowing the size of the raw data being written is useful for identifying the cause of changes to file sizes after compressing and encoding when writing to files. The implementation calculating the logical raw data size for the file will be implemented in a followup task. # Changes - Adding the optional Stats section to Tablet - `VeloxWriter.cpp`: Calculating the raw data size in bytes via running sum of memory used right before encoding and flushing - temporarily writing 0 to rawSize to maintain the status quo while the final calculation is not yet implemented. - `FieldWriter.h`: Added `rawSize()` virtual function to handle string and nullable cases. # Important Notes - In `VeloxWriter.cpp` we have special handling for chunked null streams, which is why `materialize` is called before one of the rawSize stat calculations and not the other. - `rawStripeSize` name updated for clarity. - Some investigation determined that rawStripeSize in stripe flush metrics is also currently not used anywhere. Differential Revision: D60534808
phoenixawe
force-pushed
the
export-D60534808
branch
from
b9da7db
to
4a852c6
Compare
phoenixawe
added a commit
to phoenixawe/nimble
that referenced
this pull request
Sep 19, 2024
Summary: Pull Request resolved: facebookincubator#74 Raw size will be implemented in a followup task, to better reflect logical data size that is file format agnostic. # Changes - Adding the optional Stats section to Tablet - ~~`VeloxWriter.cpp`: Calculating the raw data size in bytes via running sum of memory used right before encoding and flushing~~ - ~~`FieldWriter.h`: Added `rawSize()` virtual function to handle string and nullable cases.~~ # Important Notes - In `VeloxWriter.cpp` we have special handling for chunked null streams, which is why `materialize` is called in an if statement. - `rawStripeSize` name updated for clarity. - Some investigation determined that rawStripeSize in stripe flush metrics is also currently not used anywhere. Differential Revision: D60534808
phoenixawe
force-pushed
the
export-D60534808
branch
from
4a852c6
to
033340a
Compare
|
This pull request was exported from Phabricator. Differential Revision: D60534808 |
phoenixawe
added a commit
to phoenixawe/nimble
that referenced
this pull request
Sep 20, 2024
Summary: Pull Request resolved: facebookincubator#74 # Context Knowing the size of the raw data being written is useful for identifying the cause of changes to file sizes after compressing and encoding when writing to files. The implementation calculating the logical raw data size for the file will be implemented in a followup task. # Changes - Adding the optional Stats section to Tablet - `VeloxWriter.cpp`: Calculating the raw data size in bytes via running sum of memory used right before encoding and flushing - temporarily writing 0 to rawSize to maintain the status quo while the final calculation is not yet implemented. - `FieldWriter.h`: Added `rawSize()` virtual function to handle string and nullable cases. # Important Notes - In `VeloxWriter.cpp` we have special handling for chunked null streams, which is why `materialize` is called before one of the rawSize stat calculations and not the other. - `rawStripeSize` name updated for clarity. - Some investigation determined that rawStripeSize in stripe flush metrics is also currently not used anywhere. Differential Revision: D60534808
phoenixawe
added a commit
to phoenixawe/nimble
that referenced
this pull request
Sep 20, 2024
Summary: Pull Request resolved: facebookincubator#74 Raw size will be implemented in a followup task, to better reflect logical data size that is file format agnostic. # Changes - Adding the optional Stats section to Tablet - ~~`VeloxWriter.cpp`: Calculating the raw data size in bytes via running sum of memory used right before encoding and flushing~~ - ~~`FieldWriter.h`: Added `rawSize()` virtual function to handle string and nullable cases.~~ # Important Notes - In `VeloxWriter.cpp` we have special handling for chunked null streams, which is why `materialize` is called in an if statement. - `rawStripeSize` name updated for clarity. - Some investigation determined that rawStripeSize in stripe flush metrics is also currently not used anywhere. Differential Revision: D60534808
phoenixawe
force-pushed
the
export-D60534808
branch
from
033340a
to
8ce0fcf
Compare
|
This pull request was exported from Phabricator. Differential Revision: D60534808 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D60534808 |
phoenixawe
force-pushed
the
export-D60534808
branch
from
8ce0fcf
to
a19ba3b
Compare
phoenixawe
added a commit
to phoenixawe/nimble
that referenced
this pull request
Sep 20, 2024
Summary: Pull Request resolved: facebookincubator#74 Raw size will be implemented in a followup task, to better reflect logical data size that is file format agnostic. # Changes - Adding the optional Stats section to Tablet - ~~`VeloxWriter.cpp`: Calculating the raw data size in bytes via running sum of memory used right before encoding and flushing~~ - ~~`FieldWriter.h`: Added `rawSize()` virtual function to handle string and nullable cases.~~ # Important Notes - In `VeloxWriter.cpp` we have special handling for chunked null streams, which is why `materialize` is called in an if statement. Differential Revision: D60534808
Summary: Pull Request resolved: facebookincubator#74 Raw size will be implemented in a followup task, to better reflect logical data size that is file format agnostic. # Changes - Adding the optional Stats section to Tablet `Constants.h` - Updated some comments for clarity Differential Revision: D60534808
phoenixawe
force-pushed
the
export-D60534808
branch
from
a19ba3b
to
6f0f259
Compare
|
This pull request was exported from Phabricator. Differential Revision: D60534808 |
phoenixawe
added a commit
to phoenixawe/nimble
that referenced
this pull request
Sep 20, 2024
Summary: Pull Request resolved: facebookincubator#74 Raw size will be implemented in a followup task, to better reflect logical data size that is file format agnostic. # Changes - Adding the optional Stats section to Tablet `Constants.h` - Updated some comments for clarity Differential Revision: D60534808
|
This pull request has been merged in 9095413. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Context
Knowing the size of the raw data being written is useful for identifying the cause of changes to file sizes after compressing and encoding when writing to files.
Changes
Important Notes
VeloxWriter.cppwe have special handling for chunked null streams, which is whymaterializeis called before one of the rawSize stat calculations and not the other.rawStripeSizename updated for clarity and value is now as the name implies, which I can guarantee is correct because it calculated in the same way as raw file size.Differential Revision: D60534808