-
-
Notifications
You must be signed in to change notification settings - Fork 944
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: add release workflow #942
Conversation
Codecov Report
@@ Coverage Diff @@
## main #942 +/- ##
==========================================
- Coverage 99.65% 99.65% -0.01%
==========================================
Files 1957 1957
Lines 209831 209831
Branches 878 877 -1
==========================================
- Hits 209112 209109 -3
- Misses 699 702 +3
Partials 20 20
|
…ngesets to commit ('.changeset/**') and at the same time allow the release workflow to run when the PR is merged ('packages/**/CHANGELOG.md')
I guess the |
Just to give you some feedback. We will discuss this in our team meeting next week (Thursday). |
@ST-DDT I do appreciate the feedback. Thank you. |
I currently not have the time to look into it to deep but one of my first questions would be if Not to fully count that this PR will get merged some day, but we should use node 18 instead of 16 and you are right about that we may remove the |
@Shinigami92 yes it creates changelogs. I believe it would just add new ones at the top of your existing CHANGELOG.md When you push a commit that has a new changeset, it gets committed as usual, but the workflow sees there is a new changeset and creates (or updates) a PR which contains:
You can modify the PR in any way, like editing the changes or the title. Once the PR is merged you get the updated Now that I think about it, the workflow can run just for |
By the way I played around on my fork trying to publish a release, but the workflow keeps trying to release at faker-js rather than davidevmod, and obviously fails because it doesn't have the permission. Probably it's just a question of modifying names in the |
We will stay with the current way of generating changelogs. |
That's alright, hope you find a workflow that fits your needs. |
Hello, I randomly stumbled in this issue #268 while I was taking a look at your project to get some inspiration.
For the past few days I've been dealing with automating the releases of one of my project and as soon I saw the issue, I thought I could give some help.
I just ported the changesets/changesets solution for my yarn workspaces to your pnpm project.
I did so with the help of some documentation:
I didn't fully tested the workflow because I would need a
secrets.GITHUB_TOKEN
and asecrets.NPM_TOKEN
but I am confident that it should work. Give it a try.The way this should work is that whenever you want to add a changeset, you run
pnpm changeset
and follow the instructions.Then commit the autogenerated changeset and push to
main
.The push triggers a
release
workflow that will create a PR with the changeset, or if there was a PR already open it will just add commits to that PR.Once you merge the PR, a new release of your package is automatically published to both NPM and GitHub.
You can customize stuff and probably you also want to adopt this beatiful changeset-bot.