refactor(cactus-sys): clean up build.rs for readability and upstream portability#4111
Closed
refactor(cactus-sys): clean up build.rs for readability and upstream portability#4111
Conversation
…portability - Extract monolithic main() into focused helper functions - Use &Path instead of &PathBuf in all function signatures - Add CACTUS_SOURCE_DIR env var override via char_workspace_fallback() pattern, making the workspace-specific path easy to identify and remove when moving upstream - Consolidate #[cfg]-gated platform logic into top-level functions - Group allow attributes in src/lib.rs into a single directive Co-authored-by: Cursor <cursoragent@cursor.com>
✅ Deploy Preview for hyprnote-storybook canceled.
|
✅ Deploy Preview for hyprnote canceled.
|
- Add build.rs guard in crates/data that panics on release profile - Remove phantom hypr-data dep from plugins/listener - Remove dead get_words_onboarding() and hypr-data dep from db-user - Add deepgram.json, soniox.json fixtures for english_1 and korean_1 Co-authored-by: Cursor <cursoragent@cursor.com>
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
main()into focused helper functions (locate_cactus_source,set_rebuild_triggers,build_native_library,link_native_library,link_platform_dependencies,generate_bindings)&Pathinstead of&PathBufin all function signatures (idiomatic Rust)CACTUS_SOURCE_DIRenv var override via achar_workspace_fallback()function — the workspace-specific path is isolated and easy to delete when moving this crate tocactus-compute/cactus#[cfg]-gated platform blocks into top-level functions#![allow(...)]attributes insrc/lib.rsinto a single directiveMade with Cursor