-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(manufacturing-server): implement an export OVs endpoint #673
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
runcom
force-pushed
the
mfcg-export-ovs
branch
from
September 11, 2024 15:27
4e867cc
to
94e826f
Compare
runcom
force-pushed
the
mfcg-export-ovs
branch
from
September 18, 2024 09:46
94e826f
to
e048ac8
Compare
runcom
force-pushed
the
mfcg-export-ovs
branch
2 times, most recently
from
September 18, 2024 09:55
db05bf0
to
6b962d4
Compare
say-paul
reviewed
Sep 19, 2024
mmartinv
previously approved these changes
Sep 25, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have tested the changes and other than the comment below, it looks good to me.
runcom
force-pushed
the
mfcg-export-ovs
branch
from
September 25, 2024 09:36
6b962d4
to
2563122
Compare
Just serving an archive with all the OVs the manufacturer knows about. It'd be handy to just give this away to whoever needs these credentials and/or create a nice UI where you click a button to have them all. The post-MVP, with a UI, would be to just have a UI that is able to list all the device credentials, let you select which one you want, download them in an archive, profit. Not there yet. Signed-off-by: Antonio Murdaca <amurdaca@redhat.com>
runcom
force-pushed
the
mfcg-export-ovs
branch
from
September 25, 2024 10:02
2563122
to
0f3d464
Compare
mmartinv
approved these changes
Sep 25, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just serving an archive with all the OVs the manufacturer knows about.
It'd be handy to just give this away to whoever needs these credentials
and/or create a nice UI where you click a button to have them all.
The post-MVP, with a UI, would be to just have a UI that is able to list
all the device credentials, let you select which one you want, download
them in an archive, profit. Not there yet.
This is based on #671 - so let's merge that first
Signed-off-by: Antonio Murdaca amurdaca@redhat.com