Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(manufacturing-server): implement an export OVs endpoint #673

Merged
merged 1 commit into from
Sep 25, 2024

Conversation

runcom
Copy link
Contributor

@runcom runcom commented Sep 11, 2024

Just serving an archive with all the OVs the manufacturer knows about.
It'd be handy to just give this away to whoever needs these credentials
and/or create a nice UI where you click a button to have them all.
The post-MVP, with a UI, would be to just have a UI that is able to list
all the device credentials, let you select which one you want, download
them in an archive, profit. Not there yet.

This is based on #671 - so let's merge that first

Signed-off-by: Antonio Murdaca amurdaca@redhat.com

@runcom runcom changed the base branch from mfcg-export-ovs to main September 18, 2024 09:46
owner-onboarding-server/src/main.rs Dismissed Show dismissed Hide dismissed
store/src/pg.rs Dismissed Show dismissed Hide dismissed
@runcom runcom force-pushed the mfcg-export-ovs branch 2 times, most recently from db05bf0 to 6b962d4 Compare September 18, 2024 09:55
mmartinv
mmartinv previously approved these changes Sep 25, 2024
Copy link
Contributor

@mmartinv mmartinv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have tested the changes and other than the comment below, it looks good to me.

manufacturing-server/src/main.rs Show resolved Hide resolved
Just serving an archive with all the OVs the manufacturer knows about.
It'd be handy to just give this away to whoever needs these credentials
and/or create a nice UI where you click a button to have them all.
The post-MVP, with a UI, would be to just have a UI that is able to list
all the device credentials, let you select which one you want, download
them in an archive, profit. Not there yet.

Signed-off-by: Antonio Murdaca <amurdaca@redhat.com>
Copy link
Contributor

@mmartinv mmartinv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks!

@runcom runcom merged commit b775d03 into fdo-rs:main Sep 25, 2024
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants