feat: Added support for --azure-credential via VSCE_AZURE_CREDENTIAL environment variable
#663
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
felipecrs
reviewed
Jul 26, 2024
JakeShirley
changed the title
--azure-credential via VSCE_USE_AZURE_CREDENTIALS environment variable--azure-credential via VSCE_AZURE_CREDENTIALS environment variable
|
Validated this with my fork. Working for me! :) https://github.com/Mojang/minecraft-debugger/actions/runs/10120996092/job/27991427579 |
|
@JakeShirley, thanks a lot. I'm currently on vacation far away from the computer. I should review your PR next week. |
|
@felipecrs did you ever get a chance to look at this? :) |
felipecrs
requested changes
Aug 13, 2024
Very sorry for taking this long. I had actually forgot. |
JakeShirley
changed the title
--azure-credential via VSCE_AZURE_CREDENTIALS environment variable--azure-credential via VSCE_AZURE_CREDENTIAL environment variable
|
@felipecrs Finally got around to addressing this feedback :) |
|
Did a fresh rebase, hopefully all of the checks are good now :) |
felipecrs
approved these changes
Dec 27, 2024
|
🎉 This PR is included in version 6.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
vsce added support for
--azure-credentiala few months ago as Microsoft moves away from long-living PATs. This flag allows authentication to be pulled from the current azure cli context.This PR also does the following small tweaks:
launch.jsonto run ava tests for debugging via VS Codepublishes an extension in a non-root folderto work on Windows (some hard-coded pathing assumptions were made).gitattributesfile to force line endings to beLFinstead ofCRLF. On Windows prettier was complaining about all of the line endings, this change makes git clone/treat all of the files asLF.Closes #662