Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce tiling memory #227

Merged
merged 4 commits into from
Apr 3, 2024
Merged

Reduce tiling memory #227

merged 4 commits into from
Apr 3, 2024

Conversation

e-n-f
Copy link
Collaborator

@e-n-f e-n-f commented Apr 2, 2024 •
edited
Loading

This PR makes two changes to Tippecanoe to reduce memory consumption:

  1. As features are converted to mvt_feature to add them to the output tile, erase their serial_feature representation
  2. When the number of features scheduled to be included in the tile reaches the maximum feature count, don't wait any longer to start finding features to drop

arredond
arredond approved these changes Apr 3, 2024
View reviewed changes
Copy link

@arredond arredond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm no C++ expert but the changes seem to be quite straightforward: an additional condition that allows dropping features and test updates. Also verified in https://github.com/felt/felt/pull/10275 that the changes work as expected (and approved that one)

@e-n-f e-n-f merged commit bb4f220 into main Apr 3, 2024
4 checks passed
@e-n-f e-n-f deleted the reduce-tiling-memory branch April 3, 2024 14:12
@e-n-f e-n-f mentioned this pull request Aug 16, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arredond arredond arredond approved these changes

@migurski migurski Awaiting requested review from migurski migurski is a code owner

@dnomadb dnomadb Awaiting requested review from dnomadb dnomadb is a code owner

@ChrisLoer ChrisLoer Awaiting requested review from ChrisLoer ChrisLoer is a code owner

@ibesora ibesora Awaiting requested review from ibesora

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@e-n-f @arredond