Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

return null if key does not exist for Kv.getJson #189

Merged
merged 1 commit into from
Sep 11, 2023
Merged

return null if key does not exist for Kv.getJson #189

merged 1 commit into from
Sep 11, 2023

Conversation

karthik2804
Copy link
Collaborator

Return null instead of erroring out when the key does not exist to be in line with the behavior of get.

@karthik2804
return null if key does not exist for Kv.getJson
1c42222 
Signed-off-by: karthik2804 <karthik.ganeshram@fermyon.com>
@karthik2804 karthik2804 merged commit 36b199b into fermyon:main Sep 11, 2023
2 checks passed
@karthik2804 karthik2804 deleted the fix/get_json branch September 11, 2023 19:56
@tpmccallum tpmccallum mentioned this pull request Sep 13, 2023
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dicej dicej dicej approved these changes

@itowlson itowlson Awaiting requested review from itowlson

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@karthik2804 @dicej