replace format by f-strings

[cpanse]

Just some cosmetics. it is more of a test to practice the PR procedure.

[leoschwarz]

The PR looks good to me, but I don't understand why the functional test is failing currently.
Basically, the error message is "login or password missing".

[lbrink]

The PR looks good to me, but I don't understand why the functional test is failing currently. Basically, the error message is "login or password missing".

Seems unrelated.
Looks like in the generation for the .bfabric.py for the functional tests something went wrong.
Looks like the secrets for this test were read as empty values.
Logs show:
Run echo "_WEBBASE=\""$WEBBASE\" > ~/.bfabricrc.py echo "_WEBBASE=\""$WEBBASE\" > ~/.bfabricrc.py echo "_LOGIN=\""$LOGIN\" >> ~/.bfabricrc.py echo "_PASSWD=\""$PASSWD\" >> ~/.bfabricrc.py shell: /usr/bin/bash --noprofile --norc -e -o pipefail {0} env: pythonLocation: /opt/hostedtoolcache/Python/3.9.18/x64 LD_LIBRARY_PATH: /opt/hostedtoolcache/Python/3.9.18/x64/lib WEBBASE: LOGIN: PASSWD:
For a passed test the output would be:
Run echo "_WEBBASE=\""$WEBBASE\" > ~/.bfabricrc.py echo "_WEBBASE=\""$WEBBASE\" > ~/.bfabricrc.py echo "_LOGIN=\""$LOGIN\" >> ~/.bfabricrc.py echo "_PASSWD=\""$PASSWD\" >> ~/.bfabricrc.py shell: /usr/bin/bash --noprofile --norc -e -o pipefail {0} env: pythonLocation: /opt/hostedtoolcache/Python/3.9.18/x64 LD_LIBRARY_PATH: /opt/hostedtoolcache/Python/3.9.18/x64/lib WEBBASE: *** LOGIN: *** PASSWD: ***

[leoschwarz]

Hi @lbrink, thank you for your response and checking the cause.

The problem occurs because this PR originates from a fork of the repository and this behavior stated in the documentation:
With the exception of GITHUB_TOKEN, secrets are not passed to the runner when a workflow is triggered from a forked repository.

i.e. we cannot perform the functional test unless the PR originates from a branch of this repository. For our workflow this means it's best to create a feature branch in this repository and delete it after it's merged. (In the future we might have a better solution for the CI.)