[PoC] Make rest.request resilient to 502 Gateway Errors #83
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Occassionally when making a report using Lusid data, a gateway error will interrupt the entire report. Instead of making the ApiException try excepts even more egregious, I thought to solve the problem closer to the source, by allowing rest to recursively call itself up to 3 times when a 502 is encountered. Naturally, on the third failed 502 call, an ApiException will be raised as normal, and the "response time" for a 502 is sufficiently small, so the tradeoff on performance/reliability is worth it.
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
developbranchDescription of the PR
Occassionally when making a report using Lusid data, a gateway error will interrupt the entire report.
Instead of making the ApiException try excepts in our codebase even more egregious, I thought to solve the problem closer to the source, by allowing rest to recursively call itself up to 3 times when a 502 is encountered.
Naturally, on the third failed 502 call, an ApiException will be raised as normal, and the "response time" for a 502 is sufficiently small, so the tradeoff on performance/reliability is worth it.