Skip to content

[PoC] Make rest.request resilient to 502 Gateway Errors #83

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mb-a wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

[PoC] Make rest.request resilient to 502 Gateway Errors #83

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9fbee05
[PoC] Make rest.request resilient to 502 Gateway Errors
mb-a Jul 20, 2021
58d671b
Fix obvious self-call error
mb-a Aug 5, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 12 additions & 2 deletions sdk/lusid/rest.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,7 @@ def __init__(self, configuration, pools_size=4, maxsize=None):

def request(self, method, url, query_params=None, headers=None,
body=None, post_params=None, _preload_content=True,
_request_timeout=None):
_request_timeout=None, retries=3):
"""Perform requests.

:param method: http request method
Expand All @@ -126,7 +126,11 @@ def request(self, method, url, query_params=None, headers=None,
number provided, it will be total request
timeout. It can also be a pair (tuple) of
(connection, read) timeouts.
:param retries: times to reattempt the request if transient errors are
encountered (HTTP Error 502)
"""
argument_cache = locals()

method = method.upper()
assert method in ['GET', 'HEAD', 'DELETE', 'POST', 'PUT',
'PATCH', 'OPTIONS']
Expand Down Expand Up @@ -221,6 +225,12 @@ def request(self, method, url, query_params=None, headers=None,
# log response body
logger.debug("response body: %s", r.data)

if retries and (r.status in {502}):
logger.debug("Temporary HTTP Error %s encountered, trying again", r.status)
argument_cache["retries"] -= 1
del argument_cache["self"]
return self.request(**argument_cache)

if not 200 <= r.status <= 299:
raise ApiException(http_resp=r)

Expand Down Expand Up @@ -289,4 +299,4 @@ def PATCH(self, url, headers=None, query_params=None, post_params=None,
post_params=post_params,
_preload_content=_preload_content,
_request_timeout=_request_timeout,
body=body)
body=body)