/workflows/bulk-cancel: also cancel task with status INIT and WAIT#41
Merged
/workflows/bulk-cancel: also cancel task with status INIT and WAIT#41
Conversation
HenkKalkwater
force-pushed
the
92-bulk-cancel-not-working
branch
from
d5e3dfd to
e9c5ca7
Compare
Previously, only tasks with status PROGRESS were cancelled. This brings it in
line with /workflow/{id}/cancel.
Also added a test to verify the behaviour and changed the tasks in `setUp()`
with state 'pending' to 'wait', since 'pending' is not a valid task state.
Fixes finmars-platform/finmars-core#92
HenkKalkwater
force-pushed
the
92-bulk-cancel-not-working
branch
from
e9c5ca7 to
8e03915
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, only tasks with status PROGRESS were cancelled. This brings it in line with /workflow/{id}/cancel.
Also added a test to verify the behaviour and changed the tasks in
setUp()with state 'pending' to 'wait', since 'pending' is not a valid task state.Fixes finmars-platform/finmars-core#92