Skip to content

/workflows/bulk-cancel: also cancel task with status INIT and WAIT #41

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
paktusov merged 1 commit into from
Feb 6, 2026
Merged

/workflows/bulk-cancel: also cancel task with status INIT and WAIT #41

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 19 additions & 3 deletions workflow/tests/test_workflow_view_set.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ def setUp(self):
owner=self.user,
name="Workflow 1",
user_code="workflow1",
status="init",
status=Workflow.STATUS_INIT,
payload_data='{"key": "test1"}',
)
self.workflow1.created_at = date(2024, 6, 1)
Expand All @@ -38,7 +38,7 @@ def setUp(self):
owner=self.user,
name="Workflow 2",
user_code="workflow2",
status="pending",
status=Workflow.STATUS_WAIT,
payload_data='{"key": "test2"}',
)
self.workflow2.created_at = date(2024, 7, 1)
Expand All @@ -50,7 +50,7 @@ def setUp(self):
owner=self.user,
name="Workflow 3",
user_code="workflow3",
status="pending",
status=Workflow.STATUS_WAIT,
payload_data='{"key": "test3"}',
workflow_template=workflow_template,
)
Expand Down Expand Up @@ -95,3 +95,19 @@ def test_workflow_verions_2(self):
response = self.client.get(f"{self.url_prefix}{self.workflow3.id}/")
self.assertEqual(response.status_code, 200)
self.assertEqual(response.data["workflow_version"], 2)

def test_workflow_cancel_bulk(self):
workflows = [self.workflow1, self.workflow2, self.workflow3]
workflow_ids = list([w.id for w in workflows])

response = self.client.post(
f"{self.url_prefix}bulk-cancel/",
{
"ids": workflow_ids,
},
)

self.assertEqual(response.status_code, 200)
workflows = Workflow.objects.filter(pk__in=workflow_ids)
for workflow in workflows:
self.assertEqual(workflow.status, Workflow.STATUS_CANCELED)
4 changes: 3 additions & 1 deletion workflow/views.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -225,7 +225,9 @@ def bulk_cancel(self, request, *args, **kwargs):
valid = serializer.is_valid(raise_exception=False) # noqa: F841

data = serializer.validated_data
workflows = Workflow.objects.filter(id__in=data["ids"], status=Workflow.STATUS_PROGRESS)
workflows = Workflow.objects.filter(
id__in=data["ids"], status__in=[Workflow.STATUS_INIT, Workflow.STATUS_PROGRESS, Workflow.STATUS_WAIT]
)
for workflow in workflows:
workflow.cancel()

Expand Down