fix: bump GCS dependency to support Node 20 #145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: William Killerud <william@killerud.com>
Closed
|
I see a potential problem, in that this package creates an executable using vercel/pkg, which was recently deprecated/archived. It only has support for building Node 18 executables. I assume this happens when importing parts of this package in another script @stalet, not using the CLI, since the bug is an issue in Node 20? In other words it should probably be fine. |
nar was dropped back in #30
|
On a second scan, these built executables are only attached to the GitHub Releases. For npm/node, the binary is https://github.com/finn-no/cdn-uploader/blob/master/index.js |
|
Yeah it was just invoked from a build using node 20, and it seems to use the current node when invoking it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Drop support for Node 12, 14, 16