Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pin Chrome version 118 in CI #1049

Merged
merged 5 commits into from
Nov 9, 2023
Merged

Pin Chrome version 118 in CI #1049

merged 5 commits into from
Nov 9, 2023

Conversation

NhienLam
Copy link
Contributor

@NhienLam NhienLam commented Nov 2, 2023 •
edited
Loading

Pin Chrome v118 in CI to build and run tests.

Currently, CI test fails with

This version of ChromeDriver only supports Chrome version 114
Current browser version is 118.0.5993.117 with binary path /usr/bin/google-chrome

This is because Protractor has dev dependency on webdriver-manager, which is not supporting Chrome version > 114.

@NhienLam NhienLam changed the title Configure Protractor to use the chromedriver binary Pin Chrome version 118 in CI Nov 2, 2023
prameshj
prameshj reviewed Nov 2, 2023
View reviewed changes
Copy link
Collaborator

@prameshj prameshj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@NhienLam NhienLam merged commit f8fe7dd into master Nov 9, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prameshj prameshj prameshj approved these changes

@jamesdaniels jamesdaniels Awaiting requested review from jamesdaniels

@jhuleatt jhuleatt Awaiting requested review from jhuleatt

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@NhienLam @prameshj