Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pin Chrome version 118 in CI #1049

Merged
merged 5 commits into from
Nov 9, 2023
Merged

Pin Chrome version 118 in CI #1049

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
b2b7b4c
Configure Protractor to use the chromedriver binary
NhienLam Nov 2, 2023
7277a03
Update package-lock.json
NhienLam Nov 2, 2023
a01e523
Pin Chrome v118
NhienLam Nov 2, 2023
2369bb7
Pin chrome v118 in docker container
NhienLam Nov 2, 2023
7b3b4f7
Add TODO comment
NhienLam Nov 2, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions buildtools/container/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,5 +13,10 @@ RUN curl -fsSL --output hub.tgz https://github.com/github/hub/releases/download/
RUN tar --strip-components=2 -C /usr/bin -xf hub.tgz hub-linux-amd64-2.11.2/bin/hub

# Install the lastest Chrome stable version.
RUN wget https://dl.google.com/linux/direct/google-chrome-stable_current_amd64.deb
RUN dpkg -i google-chrome-stable_current_amd64.deb; apt-get -fy install
# RUN wget https://dl.google.com/linux/direct/google-chrome-stable_current_amd64.deb
# RUN dpkg -i google-chrome-stable_current_amd64.deb; apt-get -fy install

# Pin Chrome v118 because we're pinning this version in CI.
# TODO: Install the lastest Chrome stable version once we unpin chrome version in CI.
RUN wget http://dl.google.com/linux/chrome/deb/pool/main/g/google-chrome-stable/google-chrome-stable_118.0.5993.70_amd64.deb
RUN dpkg -i google-chrome-stable_118.0.5993.70_amd64.deb; apt-get -fy install
Loading
Loading