fix USE_V1_PUBLISH_BLOCK_ENDPOINT flag #582
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
USE_V1_PUBLISH_BLOCK_ENDPOINT was accidentally using the v2 publish endpoint when set instead of v1, and vice versa.
Codecov ReportAttention:
β Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #582 +/- ##
==========================================
- Coverage 36.22% 30.44% -5.79%
==========================================
Files 24 41 +17
Lines 5267 6268 +1001
==========================================
Hits 1908 1908
- Misses 3112 4113 +1001
Partials 247 247
Flags with carried forward coverage won't be shown. Click here to find out more. β View full report in Codecov by Sentry. |
avalonche
reviewed
Feb 12, 2024
avalonche
reviewed
Feb 12, 2024
avalonche
previously approved these changes
Feb 13, 2024
avalonche
approved these changes
Feb 13, 2024
|
Fixed in #585 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
π Summary
USE_V1_PUBLISH_BLOCK_ENDPOINT was accidentally using the v2 publish endpoint when set instead of v1, and vice versa.
β± Motivation and Context
π References
fixes #581
β I have run these commands
(used the web editor)
make lintmake test-racego mod tidyCONTRIBUTING.md