Publish block V1 flag fix #585
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
USE_V1_PUBLISH_BLOCK_ENDPOINT was accidentally using the v2 publish endpoint when set instead of v1, and vice versa.
avalonche
force-pushed
the
publish-block-fix
branch
from
11a2ba2 to
78b0c1b
Compare
Codecov ReportAttention:
β Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #585 +/- ##
==========================================
- Coverage 36.22% 30.44% -5.79%
==========================================
Files 24 41 +17
Lines 5267 6268 +1001
==========================================
Hits 1908 1908
- Misses 3112 4113 +1001
Partials 247 247
Flags with carried forward coverage won't be shown. Click here to find out more. β View full report in Codecov by Sentry. |
avalonche
force-pushed
the
publish-block-fix
branch
10 times, most recently
from
7ae5cbc to
0e75ea2
Compare
avalonche
force-pushed
the
publish-block-fix
branch
from
0e75ea2 to
f10ae18
Compare
|
for some reason the linter was panicking in #582, this includes a linter upgrade |
metachris
reviewed
Feb 15, 2024
| @@ -30,6 +30,7 @@ linters: | |||
| - deadcode | |||
| - varcheck | |||
| - interfacebloat | |||
| - exhaustruct | |||
There was a problem hiding this comment.
why disable this linter rule?
There was a problem hiding this comment.
it was causing too many linter issues as there are many paths that are not ignored. I will have a follow up to properly update the go version and linter
metachris
reviewed
Feb 15, 2024
| @@ -14,7 +14,7 @@ jobs: | |||
| - name: Set up Go | |||
| uses: actions/setup-go@v3 | |||
| with: | |||
| go-version: ^1.20 | |||
| go-version: ^1.21 | |||
metachris
reviewed
Feb 15, 2024
| @@ -1,6 +1,6 @@ | |||
| module github.com/flashbots/mev-boost-relay | |||
|
|
|||
| go 1.20 | |||
| go 1.21 | |||
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
π Summary
Same as #582 but with some linter fixes and comments addressed as for some reason the linter was panicking
β± Motivation and Context
See #581
π References
β I have run these commands
make lintmake test-racego mod tidyCONTRIBUTING.md