Feature/clarify package generation process #24324
Conversation
parsimeikoikai
had a problem deploying
to
Docker Hub
GitHub Actions
Failure
|
Hi @jacobshandling , |
| if (packageType === "deb") { | ||
| return " For CentOS, Red Hat, and Fedora Linux, use --type=rpm."; | ||
| } else if (packageType === "msi") { | ||
| return " Windows can only generate an MSI package."; |
There was a problem hiding this comment.
Not sure that this conveys information correctly, since we're talking about building an MSI package, which any OS can do (with the correct dependencies), not building from a specific OS.
There was a problem hiding this comment.
Yeah, I'm specifically commenting here about the copy for this line; swapping "enroll the host" to "build the installer package" makes sense. I made some updates to the guide linked here recently, hence being picky about how we word things.
There was a problem hiding this comment.
@iansltx ,I think I missed the link would you mind sharing the link again?Also,I have updated the PR
|
@parsimeikoikai A lot of the build steps will fail on forks, including the Docker one, so no need to resolve that one to have the PR in a ready state. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #24324 +/- ##
========================================
Coverage 63.43% 63.44%
========================================
Files 1582 1590 +8
Lines 150353 150849 +496
Branches 3822 3942 +120
========================================
+ Hits 95381 95706 +325
- Misses 47373 47534 +161
- Partials 7599 7609 +10
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
| @@ -254,7 +254,7 @@ const PlatformWrapper = ({ | |||
| <> | |||
| {packageType !== "plain-osquery" && ( | |||
| <span className={`${baseClass}__cta`}> | |||
| Run this command with the{" "} | |||
| Run this command to generate an install package with the updated{" "} | |||
There was a problem hiding this comment.
"to generate an install package"
+1 on explaining what running the command will do
There was a problem hiding this comment.
I think we should stick with the label/help text copy from the Figma: we settled on keeping the label short but updating the help text to include "Install this package…" to make it clearer what the command does.
There was a problem hiding this comment.
@rachaelshaw ,
According to the figma file linked here, the text should read :
- Install this package to add hosts to Fleet. For CentOS, Red Hat, and Fedora Linux, use --type=rpm. (For windows)
- Install this package to add hosts to Fleet. For Windows, this generates an MSI package. (For Linux)
- Install this package to add hosts to Fleet . (For Macos)
Right?
There was a problem hiding this comment.
@rachaelshaw Just a reminder to review this when you're back from the holiday break.
parsimeikoikai
had a problem deploying
to
Docker Hub
GitHub Actions
Failure
parsimeikoikai
force-pushed
the
feature/clarify-package-generation-process
branch
from
9428777 to
f82c2a4
Compare
parsimeikoikai
had a problem deploying
to
Docker Hub
GitHub Actions
Failure
parsimeikoikai
had a problem deploying
to
Docker Hub
GitHub Actions
Failure
frontend/components/AddHostsModal/PlatformWrapper/PlatformWrapper.tsx
Outdated
Show resolved
Hide resolved
frontend/components/AddHostsModal/PlatformWrapper/PlatformWrapper.tsx
Outdated
Show resolved
Hide resolved
rachaelshaw
had a problem deploying
to
Docker Hub
GitHub Actions
Failure
rachaelshaw
requested review from
RachelElysia and
jacobshandling
and removed request for
RachelElysia
frontend/components/AddHostsModal/PlatformWrapper/PlatformWrapper.tsx
Outdated
Show resolved
Hide resolved
jacobshandling
had a problem deploying
to
Docker Hub
GitHub Actions
Failure
Checklist for submitter
Updated the help text to clarify that the command shown is for generating install packages, not enrolling devices. Added a note for Windows users to specify that only MSI packages can be generated.
See #25305