Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/clarify package generation process #24324

Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -56,9 +56,9 @@
interface IPlatformWrapperProps {
enrollSecret: string;
onCancel: () => void;
certificate: any;

Check warning on line 59 in frontend/components/AddHostsModal/PlatformWrapper/PlatformWrapper.tsx

View workflow job for this annotation

GitHub Actions / lint-js (ubuntu-latest)

Unexpected any. Specify a different type
isFetchingCertificate: boolean;
fetchCertificateError: any;

Check warning on line 61 in frontend/components/AddHostsModal/PlatformWrapper/PlatformWrapper.tsx

View workflow job for this annotation

GitHub Actions / lint-js (ubuntu-latest)

Unexpected any. Specify a different type
config: IConfig | null;
}

Expand Down Expand Up @@ -263,7 +263,7 @@
>
Fleet command-line tool
</a>{" "}
installed:
:
</span>
)}{" "}
<span className="buttons">
Expand Down Expand Up @@ -338,6 +338,16 @@
}
}`,
};
const getHelpTextForPackageType = (): string => {
if (packageType === "deb") {
return "Install this package to add hosts to Fleet. For CentOS, Red Hat, and Fedora Linux, use --type=rpm.";
} else if (packageType === "msi") {
return "Install this package to add hosts to Fleet. For Windows, this generates an MSI package.";
} else if (packageType === "pkg") {
return "Install this package to add hosts to Fleet.";
}
return "";
};

if (packageType === "chromeos") {
return (
Expand Down Expand Up @@ -545,11 +555,7 @@
label={renderLabel(packageType, renderInstallerString(packageType))}
type="textarea"
value={renderInstallerString(packageType)}
helpText={`Distribute your package to add hosts to Fleet.${
packageType === "deb"
? " For CentOS, Red Hat, and Fedora Linux, use --type=rpm."
: ""
}`}
helpText={`${getHelpTextForPackageType()}`}
/>
</>
);
Expand Down
Loading