Added ability to upload profiles with secret variables using the /configuration_profiles endpoint. #25012
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…figuration_profiles endpoint.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #25012 +/- ##
=======================================
Coverage 63.78% 63.79%
=======================================
Files 1610 1610
Lines 153230 153232 +2
Branches 3959 4012 +53
=======================================
+ Hits 97743 97755 +12
+ Misses 47695 47684 -11
- Partials 7792 7793 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
ghernandez345
temporarily deployed
to
Docker Hub
GitHub Actions
Inactive
5 tasks
lucasmrod
reviewed
Dec 30, 2024
| @@ -19,8 +19,9 @@ func Up_20241209164540(tx *sql.Tx) error { | |||
| id INT UNSIGNED NOT NULL AUTO_INCREMENT, | |||
| name VARCHAR(255) NOT NULL, | |||
| value BLOB NOT NULL, -- 64KB max value size | |||
| created_at TIMESTAMP(6) NOT NULL DEFAULT CURRENT_TIMESTAMP(6), | |||
| updated_at TIMESTAMP(6) NOT NULL DEFAULT CURRENT_TIMESTAMP(6) ON UPDATE CURRENT_TIMESTAMP(6), | |||
| -- Using DATETIME instead of TIMESTAMP to prevent future Y2K38 issues, since updated_at is used as a trigger to resend profiles | |||
There was a problem hiding this comment.
Should this be a new pattern? Or is this just for this one case?
There was a problem hiding this comment.
DATETIME uses more storage than TIMESTAMP. We can discuss in backend sync.
There was a problem hiding this comment.
OK, is this change for the next PR?
There was a problem hiding this comment.
Yes, I just wanted to get it in since I wasn't sure if the next PR would make the cut/release.
lucasmrod
approved these changes
Dec 30, 2024
getvictor
added a commit
that referenced
this pull request
Dec 30, 2024
#24900 This PR includes and depends on PR #25012, which should be reviewed/merged before this one. Windows profiles are not included in this PR due to issue #25030 This PR adds the following functionality: Apple config/DDM profile is resent to the device when the profile contains secret variables, and the values of those variables have changed. For example. - Upload secret variables - Upload profile - Device gets profile - Upload the same profile - Nothing happens - Upload a different secret variable value - Upload the same profile - Device gets updated profile # Checklist for submitter - [x] Changes file added for user-visible changes in `changes/`, `orbit/changes/` or `ee/fleetd-chrome/changes`. See [Changes files](https://github.com/fleetdm/fleet/blob/main/docs/Contributing/Committing-Changes.md#changes-files) for more information. - [x] Added/updated tests - [x] If database migrations are included, checked table schema to confirm autoupdate - For database migrations: - [x] Checked schema for all modified table for columns that will auto-update timestamps during migration. - [x] Manual QA for all new/changed functionality
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added ability to upload profiles with secret variables using the /configuration_profiles endpoint.
#25011
Checklist for submitter