[ci] Adds more ci checks for batch release file integrity by chunhtai · Pull Request #10859 · flutter/packages

chunhtai · 2026-01-22T23:27:38Z

also opts in go_router

Pre-Review Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the gemini-code-assist bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.

Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩² ↩³

gemini-code-assist

Code Review

This pull request enhances the CI checks for batch release file integrity by adding validation for workflow files, triggers, and branches for packages that opt into batch releases. It also opts in the go_router package to this new system. The changes are well-tested and improve the reliability of the release process. I have a few suggestions to further improve the robustness of the new checks and clean up a minor code duplication issue in the tests.

script/tool/lib/src/repo_package_info_check_command.dart

packages/go_router/pending_changelogs/convert_batch.yaml

script/tool/lib/src/repo_package_info_check_command.dart

chunhtai · 2026-01-29T22:54:08Z

reason for override, ci change that doesn't affect go_router functionality

stuartmorgan-g

LGTM with minor changes, but per my comment on the docs PR I just realized we haven't fixed update-release-info yet. Since that's what we tell contributors to use, we shouldn't land this until that's been updated.

stuartmorgan-g · 2026-02-03T15:26:50Z

packages/go_router/pending_changelogs/convert_batch.yaml

@@ -0,0 +1,3 @@
+changelog: |
+  - Converts go_router to use batch release.


I thought the resolution of the comment thread was that this wasn't going to have a changelog entry?

There is no change in any part of the package that affects clients.

stuartmorgan-g · 2026-02-03T15:35:04Z

script/tool/lib/src/repo_package_info_check_command.dart

+    }
+
+    final String content = workflowFile.readAsStringSync();
+    YamlMap? yaml;


Nit: final

chunhtai · 2026-02-11T19:43:44Z

script/tool/test/repo_package_info_check_command_test.dart

      workflowDir
          .childFile('release_from_branches.yml')
-          .writeAsStringSync('something');
+          .writeAsStringSync('name: something');


so that it won't trigger invalid yaml error which is not the focus of this test

auto-submit · 2026-02-11T20:14:03Z

autosubmit label was removed for flutter/packages/10859, because - The status or check suite Mac_arm64 ios_platform_tests_shard_3 master has failed. Please fix the issues identified (or deflake) before re-applying this label.

The status or check suite Linux_android android_platform_tests_shard_4 master has failed. Please fix the issues identified (or deflake) before re-applying this label.
The status or check suite Linux_android android_platform_tests_shard_2 master has failed. Please fix the issues identified (or deflake) before re-applying this label.

…lutter/packages#10859)

flutter/packages@1e50195...af1d610 2026-02-12 brunocorona.alcantar@gmail.com [video_player_avfoundation] Fix regression where http headers were ignored (flutter/packages#10991) 2026-02-12 47866232+chunhtai@users.noreply.github.com [ci] Adds more ci checks for batch release file integrity (flutter/packages#10859) 2026-02-12 stuartmorgan@google.com [google_maps_flutter] Create SDK 9 and 10 packages for iOS (flutter/packages#10852) 2026-02-12 katelovett@google.com Update codeowners (flutter/packages#11004) 2026-02-11 engine-flutter-autoroll@skia.org Roll Flutter (stable) from 67323de to 44a626f (1372 revisions) (flutter/packages#10999) 2026-02-11 stuartmorgan@google.com [video_player] Convert iOS unit tests to Swift (flutter/packages#10989) 2026-02-11 47866232+chunhtai@users.noreply.github.com [ci] updates `update-release-info` to support batch release (flutter/packages#10958) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

github-actions bot added p: go_router triage-framework Should be looked at in framework triage labels Jan 22, 2026

chunhtai force-pushed the go_router_optin branch 2 times, most recently from 32a0557 to dcd190f Compare January 27, 2026 23:32

chunhtai marked this pull request as ready for review January 27, 2026 23:32

chunhtai requested a review from stuartmorgan-g January 27, 2026 23:32

gemini-code-assist bot reviewed Jan 27, 2026

View reviewed changes

script/tool/lib/src/repo_package_info_check_command.dart Outdated Show resolved Hide resolved

script/tool/lib/src/repo_package_info_check_command.dart Outdated Show resolved Hide resolved

stuartmorgan-g requested changes Jan 28, 2026

View reviewed changes

packages/go_router/pending_changelogs/convert_batch.yaml Outdated Show resolved Hide resolved

script/tool/lib/src/repo_package_info_check_command.dart Outdated Show resolved Hide resolved

script/tool/lib/src/repo_package_info_check_command.dart Show resolved Hide resolved

chunhtai added the override: no versioning needed Override the check requiring version bumps for most changes label Jan 29, 2026

chunhtai requested a review from stuartmorgan-g January 29, 2026 22:55

stuartmorgan-g approved these changes Feb 3, 2026

View reviewed changes

chunhtai mentioned this pull request Feb 4, 2026

[ci] updates update-release-info to support batch release #10958

Merged

11 tasks

chunhtai added 16 commits February 11, 2026 10:14

[ci] Adds more ci check for batch release file integrity

a2151bd

update

b2b3eb7

fix test

70e483e

update

ee7e066

update

f90fd7a

update

39130bf

update

3200f6d

update

ba6194b

update

61c3e7d

update

fdd703c

update

703d094

new line

e4bc03e

update

60548b3

fix test

419f43a

addressing comment

454fb4e

update

a9cad1f

chunhtai force-pushed the go_router_optin branch from 875413e to 10fd358 Compare February 11, 2026 18:23

chunhtai force-pushed the go_router_optin branch from 10fd358 to 9c2244e Compare February 11, 2026 18:43

update

60dfe25

chunhtai force-pushed the go_router_optin branch from 9c2244e to 60dfe25 Compare February 11, 2026 19:36

chunhtai commented Feb 11, 2026

View reviewed changes

chunhtai added the autosubmit Merge PR when tree becomes green via auto submit App label Feb 11, 2026

auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Feb 11, 2026

chunhtai added the autosubmit Merge PR when tree becomes green via auto submit App label Feb 11, 2026

auto-submit bot merged commit 73dfeaa into flutter:main Feb 12, 2026
81 checks passed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 12, 2026

73dfeaa21 [ci] Adds more ci checks for batch release file integrity (f…

85b6206

…lutter/packages#10859)

engine-flutter-autoroll mentioned this pull request Feb 12, 2026

Roll Packages from 1e5019501fe2 to 73dfeaa21c03 (6 revisions) flutter/flutter#182296

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 12, 2026

73dfeaa21 [ci] Adds more ci checks for batch release file integrity (f…

20feab3

…lutter/packages#10859)

engine-flutter-autoroll mentioned this pull request Feb 12, 2026

Roll Packages from 1e5019501fe2 to af1d610094c3 (7 revisions) flutter/flutter#182298

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[ci] Adds more ci checks for batch release file integrity#10859

[ci] Adds more ci checks for batch release file integrity#10859
auto-submit[bot] merged 17 commits intoflutter:mainfrom
chunhtai:go_router_optin

chunhtai commented Jan 22, 2026

Uh oh!

gemini-code-assist bot left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

chunhtai commented Jan 29, 2026

Uh oh!

stuartmorgan-g left a comment

Uh oh!

stuartmorgan-g Feb 3, 2026

Uh oh!

stuartmorgan-g Feb 3, 2026

Uh oh!

chunhtai Feb 11, 2026

Uh oh!

auto-submit bot commented Feb 11, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

		@@ -0,0 +1,3 @@
		changelog: \|
		- Converts go_router to use batch release.

Conversation

chunhtai commented Jan 22, 2026

Pre-Review Checklist

Footnotes

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

chunhtai commented Jan 29, 2026

Uh oh!

stuartmorgan-g left a comment

Choose a reason for hiding this comment

Uh oh!

stuartmorgan-g Feb 3, 2026

Choose a reason for hiding this comment

Uh oh!

stuartmorgan-g Feb 3, 2026

Choose a reason for hiding this comment

Uh oh!

chunhtai Feb 11, 2026

Choose a reason for hiding this comment

Uh oh!

auto-submit bot commented Feb 11, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants