feat(cond): air conditioning failures

[mjuhe]

Summary of Changes

This PR introduces failures for the Air Conditioning System. In order to do this properly, the system has been modified slightly to more accurately model an A320 equiped with an ACSC. Other additions/changes are:

• ARINC discrete communication
• Valve simulation and travel time (TAPRV and TAV) and pack realistic temperature response time (until packs are modelled)

Failable items:

• ACSC 1 & 2 (each lane individually)
• Trim Air Pressure Regulating Valve
• Trim Air Valves
• Cabin Fan 1 & 2
• Lavatory and Galley Fan

Other failures:

• Trim air system high pressure
• Duct overheat

All associated ECAM warnings have been added as well.

Screenshots (if necessary)

References

Additional context

This PR will have conflicts with #8086, this one should be merged first as it has the fix for the temperature jumping when the valves are open and closed.

Discord username (if different from GitHub):

Testing instructions

What to look for in each of the failures:

• ACSC -> One lane fault: No effect as the second lane takes over. You will see a “COND CTL 1(2)-A(B) FAULT” ECAM warning (no chime) if you have engines off, otherwise no warning.
• ACSC -> Two lane fault: The related pack is lost, and the hot air pressure-regulating valve and trim air valves close. You will get a “AIR PACK 1(2) FAULT” ECAM warning (single chime). Temperature regulation is lost.
• Trim Air Pressure Regulating Valve: The “hot air” valve is stuck in position. If it fails open this has no effect. If it fails closed temperature optimisation is lost. You will only get a “HOT AIR FAULT” when the valve disagrees with the commanded position. The best way to test this is to fail the valve and then press the overhead button (if it was open, this will command closure). You will get the warning after a certain period of time. Observe the FAULT light illuminate on the overhead.
• Trim Air System High Pressure: Hot air pressure increases but no observable effect. You will get a “COND TRIM AIR SYS FAULT” and “TRIM AIR HI PR” ECAM message (no chime).
• [ZONE] Trim Air Valve: Optimised temperature regulation of the corresponding zone is lost. You will get a “COND TRIM AIR SYS FAULT” and “[ZONE] TRIM VALVE” ECAM message (no chime).
• [ZONE] Duct Overheat: The duct temperature rises above 88C. The TAPRV and trim air valves close. Temperature optimization is lost. You will get a “COND FWD CAB/AFT CAB/CKPT DUCT OVHT” ECAM warning (single chime). If you like to see things burn you can fail the TAPRV open, then trigger an overheat and see what happens 😛.
• Cabin Fan: One cabin fan failure reduces the recirculated flow, if both fail there is no air recirculation. You can see an amber “FAN” message appear in the COND page. You will get a “COND L+R CAB FAN FAULT” alert if both fail.
• Lav and Galley Fan: Cabin zone temperature sensors are ventilated by the air extracted by the fan. Cabin zone temperature regulation is lost. You will get a “COND LAV + GALLEY FAN FAULT” ECAM warning (single chime).

I might’ve forgotten something in my instructions; a lot of these failures are interconnected so if you see something strange make sure to put it in the comments!

Validate that the air conditioning system (without any failures) works as before.

How to download the PR for QA

Every new commit to this PR will cause a new A32NX artifact to be created, built, and uploaded.

1. Make sure you are signed in to GitHub
2. Click on the Checks tab on the PR
3. On the left side, click on the bottom PR tab
4. Click on the A32NX download link at the bottom of the page

[Gurgel100]

Great work

[mjuhe]

Thanks a lot @Gurgel100 and @Benjozork for the review!! All changes made following your suggestions.

[Gurgel100]

Great work as always.

outdated

[2hwk]

Grab an FCOM and go to the abnormal procedures section. Trigger failures and ensure the system behaves as expected. Note some failures don't immediatelly trigger an ECAM warning.
Validate that the air conditioning system (without any failures) works as before.

Behaves as expected is quite vague for testers, especially when it comes to PRs which add failures, maybe elaborate more upon this. Approved for QA with this in mind.

[mjuhe]

Behaves as expected is quite vague for testers, especially when it comes to PRs which add failures, maybe elaborate more upon this. Approved for QA with this in mind.

I've added detailed instructions now for testing and resolved merged conflicts, thanks for the approval!

[alepouna]

QA Report

Discord: alepouna
Object of testing: #8178
Tier of Testing : 2
Date : 20/09/2023

Testing Process:

• [PASS] ACSC -> One lane fault: No effect as the second lane takes over. You will see a “COND CTL 1(2)-A(B) FAULT” ECAM warning (no chime) if you have engines off, otherwise no warning.
• [PASS] ACSC -> Two lane fault: The related pack is lost, and the hot air pressure-regulating valve and trim air valves close. You will get a “AIR PACK 1(2) FAULT” ECAM warning (single chime). Temperature regulation is lost.
• [PASS] Trim Air Pressure Regulating Valve: The “hot air” valve is stuck in position. If it fails open this has no effect. If it fails closed temperature optimisation is lost. You will only get a “HOT AIR FAULT” when the valve disagrees with the commanded position. The best way to test this is to fail the valve and then press the overhead button (if it was open, this will command closure). You will get the warning after a certain period of time. Observe the FAULT light illuminate on the overhead.
• [PASS] Trim Air System High Pressure: Hot air pressure increases but no observable effect. You will get a “COND TRIM AIR SYS FAULT” and “TRIM AIR HI PR” ECAM message (no chime).
• [PASS] Cockpit Trim Air Valve: Optimised temperature regulation of the corresponding zone is lost. You will get a “COND TRIM AIR SYS FAULT” and “[ZONE] TRIM VALVE” ECAM message (no chime).
• [PASS] Forward Zone
• [PASS] Aft Zone
• [PASS] Cockpit Duct Overheat: The duct temperature rises above 88C. The TAPRV and trim air valves close. Temperature optimization is lost. You will get a “COND FWD CAB/AFT CAB/CKPT DUCT OVHT” ECAM warning (single chime). If you like to see things burn you can fail the TAPRV open, then trigger an overheat and see what happens 😛.
• [PASS] Forward Zone
• [PASS] Aft Zone
• [PASS] Cabin Fan: One cabin fan failure reduces the recirculated flow, if both fail there is no air recirculation. You can see an amber “FAN” message appear in the COND page. You will get a “COND L+R CAB FAN FAULT” alert if both fail.
• [PASS] Lav and Galley Fan: Cabin zone temperature sensors are ventilated by the air extracted by the fan. Cabin zone temperature regulation is lost. You will get a “COND LAV + GALLEY FAN FAULT” ECAM warning (single chime).

Testing Results:
Passed

Notes:
Cool (and hot) beans!! Really cool (pun intended) stuff :D