fix(cond): Fix SD COND page duct ovht indicator #8234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tracernz
requested changes
Sep 28, 2023
| @@ -130,7 +130,7 @@ type CondUnitProps = { | |||
|
|
|||
| const CondUnit = ({ title, trimAirValve, cabinTemp, trimTemp, x, y, offset, hotAir } : CondUnitProps) => { | |||
| const rotateTemp = offset + (trimAirValve * 86 / 100); | |||
| const overheat = trimTemp > 80; | |||
| const overheat = trimTemp > 176; // Overheat indicator at 80C, temperature is given in F | |||
There was a problem hiding this comment.
This doesn't make sense. The temp is only F here if you select alternate units. The problem is really that the unit conversions are done too early. Should be at the point they're used in the UI only.
There was a problem hiding this comment.
You...are absolutely correct, and I'm not sure how I managed to mix that logic up in my head. Somehow I had it flipped and thought it would convert to F if the units were set to C. I'll work on a more complete change which converts the units later.
2hwk
added
the
Waiting For Response
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
PR #8178 added a few failures for air conditioning, including a few changes to the status page. One of these was to indicate duct temperatures as amber if they exceed the overheat threshold. This is meant to happen at 80 degrees Celsius, but because of the way that the COND page converts all temperatures to Fahrenheit, it was triggering at 80 Fahrenheit instead.
This fixes the indicator to properly trigger above 80C (176F).
Screenshots (if necessary)
References
Additional context
Discord username (if different from GitHub): Eearslya
Testing instructions
How to download the PR for QA
Every new commit to this PR will cause a new A32NX artifact to be created, built, and uploaded.