Skip to content

fix(cond): Fix SD COND page duct ovht indicator #8234

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

fix(cond): Fix SD COND page duct ovht indicator #8234

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion fbw-a32nx/src/systems/instruments/src/SD/Pages/Cond/Cond.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,7 +130,7 @@ type CondUnitProps = {

const CondUnit = ({ title, trimAirValve, cabinTemp, trimTemp, x, y, offset, hotAir } : CondUnitProps) => {
const rotateTemp = offset + (trimAirValve * 86 / 100);
const overheat = trimTemp > 80;
const overheat = trimTemp > 176; // Overheat indicator at 80C, temperature is given in F
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't make sense. The temp is only F here if you select alternate units. The problem is really that the unit conversions are done too early. Should be at the point they're used in the UI only.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You...are absolutely correct, and I'm not sure how I managed to mix that logic up in my head. Somehow I had it flipped and thought it would convert to F if the units were set to C. I'll work on a more complete change which converts the units later.


return (
<SvgGroup x={x} y={y}>
Expand Down