-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(fma): continuation of presel text fix #8328
fix(fma): continuation of presel text fix #8328
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a small formatting fix.
Hm, not sure if we need a new character in the font for this. From the refs for example here it looks like it could simply be a smaller font size compared to the rest? Also, is it strictly necessary to have the two different text fields? Seems unnecessarily complicated to me |
The vertical alignment of the : relative to the baseline is very different to what's currently in the font. |
Yeah I used shomas pics and maybe I wasn't clear enough, i meant the space/gap after the ":" which seems to be smaller in the SPEED SEL case. Regarding the colon, I can add a third element if that's preferable |
I don't know if that's preferable, just giving alternatives |
Co-authored-by: Michael Corcoran <tracer@outlook.co.nz>
Quality Assurance Trainee Report Discord : popespice Testing Process: Negatives: Testing Results: Conclusions: |
Fixes #8217
Summary of Changes
This PR adds ":" to the SPEED SEL and MACH SEL text and slightly adjusts their position(continuation of #8230).
Screenshots (if necessary)
Left side is after while right side is before.
References
Provided in #8230
Additional context
I had to map the "|" character to a bottom ":" character in the font file considering it is shared between multiple displays. Since the preselect ":" is aligned to the bottom, using the existing ":" would not work.
Discord username (if different from GitHub):
bruno_pt99
Testing instructions
Preselect a speed in the PERF CLB page (before takeoff). Make sure speed sel shows on the FMA with the ":" (if A/B is armed, it will only show after A/B message disappears).
Preselect a mach speed in the PERF CRZ page. Once climb phase is active make sure mach sel shows on the FMA with the ":".
How to download the PR for QA
Every new commit to this PR will cause a new A32NX artifact to be created, built, and uploaded.