fix: show preselected speed and mach accordingly

[aaronschweig]

Fixes #8217

Summary of Changes

I added the colons to the SPEED SEL and MACH SEL messages in the FMA.tsx

Screenshots (if necessary)

References

Shown in the original issue #8217

Additional context

This is my first PR in this Repo - if I missed something or did something wrong please let me know - happy to learn!

Discord username (if different from GitHub):

Testing instructions

How to download the PR for QA

Every new commit to this PR will cause a new A32NX artifact to be created, built, and uploaded.

1. Make sure you are signed in to GitHub
2. Click on the Checks tab on the PR
3. On the left side, click on the bottom PR tab
4. Click on the A32NX download link at the bottom of the page

[becas22]

@aaronschweig it's missing the MACH SEL edit in line 634 of FMA.tsx, no?

[aaronschweig]

@becas22 of course it does - stupid me even asked in the issue but forgot to commit it. Sorry for that 😄

[BlueberryKing]

Hi, thank you for the PR! Can you add a changelog entry? Also, I'm a bit unsure if there is a space after the colon, but I'd have to compare how it looks in the sim vs. the references.

[tracernz]

Should have a changelog entry, and ideally a screenshot for all graphical changes.

-e- Also, is the colon the right size? It looks smaller than the surrounding text in the photograph on the linked issue.

[aaronschweig]

Hey sorry for the long delay, real life came in!

I took some screenshots from in the sim:

(Active pause just kept increasing the speed 😋 )

SPEED SEL:

MACHSEL:

After comparing it with the example in the original issue it looks like the space should go away, but I could also be mistaken due to the angle of the screenshot in the original issue. But also wrt the reference manual provided by @becas22 it looks like there should not be a space. What do you think?

[becas22]

@aaronschweig yeah, looks like the space needs to go. Can you provide some screenshots without the space?

[tshomas]

Got this one today from work in case you still need refs!

Tried to get a speed sel but happened too quickly

[aaronschweig]

Here is a screenshot without the space:

[becas22]

From Shomas pic it seems that:

• the ":" are aligned at the bottom of the line;
• There seems to be some space but not a whole one.

@aaronschweig do you think these are possible to implement? Otherwise I would say that the one without the space looks the best

[aaronschweig]

I played around a bit, but making it smaller or try fiddleing with the whitespace would involve messing with the text node of the svg in one way or the other. I couldn't figure out a way that looks right and works with a reasonable amount of changes in the code.

Also one question to the changelos: Is it just written by myself or autogenerated?

[becas22]

Then I would say that it looks better now (without the space) than what it was before (with no : at all)

I would say that the changelog needs to be done by you. Take a look at this PR by BBKing for example: be80aa9

Yours should be here: https://github.com/aaronschweig/aircraft/blob/master/.github/CHANGELOG.md

[tshomas]

Another one, not the clearest unfortunately though!

[BravoMike99]

Hi @aaronschweig do you plan on working this further? I wouldn't mind taking a look at this issue in case you don't plan to.

[aaronschweig]

Hey @BravoMike99 yes please feel free to continue and make changes!

[BravoMike99]

@aaronschweig just a FYI, I created #8328 as a continuation of this PR and gave you credits on the changelog. I guess in the meantime this PR can be closed.

[Maximilian-Reuter]

Closed as continuation is happening in different PR